From 9d40cdee7f523cc7ead17d5046493323ead122da Mon Sep 17 00:00:00 2001
From: Bo Gustavsson <bosse@gustavsson.one>
Date: Fri, 15 May 2026 00:00:16 +0200
Subject: [PATCH] Bug 38361: Gender field does not include a Required if the
 field is set to required in PatronSelfRegistrationBorrowerMandatoryField

Solves this bug and enhances the user experiance by replacing the old radio buttons with a less-confusing dropdown menu.

Test plan:

1. Open the setting "PatronSelfRegistrationBorrowerMandatoryField", find Gender(sex) and mark it as not required.
2. Go to the self registration form. No 'Required' label under gender.
3. Go back to the setting  "PatronSelfRegistrationBorrowerMandatoryField", find Gender(sex) and mark it as required.
4. Go to the self registration form. The 'Required' label is there.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 .../bootstrap/en/modules/opac-memberentry.tt  | 35 ++++++-------------
 1 file changed, 10 insertions(+), 25 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
index f3d4138463..4fd93491ae 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
@@ -554,34 +554,19 @@
                                             [% END %]
 
                                             [% UNLESS hidden.defined('sex') %]
-                                                <li class="lradio">
-                                                    <div class="label">Gender:</div>
-                                                    <label for="sex-female" class="radio inline"><span class="patronsex-female">Female:</span></label>
-                                                    [% IF borrower.sex == 'F' %]
-                                                        <input type="radio" name="borrower_sex" id="sex-female" value="F" checked="checked" />
-                                                    [% ELSE %]
-                                                        <input type="radio" name="borrower_sex" id="sex-female" value="F" />
-                                                    [% END %]
+                                                <li>
+                                                    <label for="sex" class="[% required.sex | html %]">Gender:</label>
 
-                                                    <label for="sex-male" class="radio inline"><span class="patronsex-male">Male:</span></label>
-                                                    [% IF borrower.sex == 'M' %]
-                                                        <input type="radio" name="borrower_sex" id="sex-male" value="M" checked="checked" />
-                                                    [% ELSE %]
-                                                        <input type="radio" name="borrower_sex" id="sex-male" value="M" />
-                                                    [% END %]
+                                                    <select id="sex" name="borrower_sex" class="[% required.sex | html %] [% IF mandatory.sex && !borrower.sex %]missing_required[% END %]" [% IF mandatory.sex %]required[% END %]>
+                                                        <option value="">None specified</option>
 
-                                                    <label for="sex-other" class="radio inline"><span class="patronsex-other">[% tp('gender','Other:') | html %]</span></label>
-                                                    [% IF borrower.sex == 'O' %]
-                                                        <input type="radio" name="borrower_sex" id="sex-other" value="O" checked="checked" />
-                                                    [% ELSE %]
-                                                        <input type="radio" name="borrower_sex" id="sex-other" value="O" />
-                                                    [% END %]
+                                                        <option value="F" [% IF borrower.sex == 'F' %]selected="selected"[% END %]>Female</option>
+                                                        <option value="M" [% IF borrower.sex == 'M' %]selected="selected"[% END %]>Male</option>
+                                                        <option value="O" [% IF borrower.sex == 'O' %]selected="selected"[% END %]>Other</option>
+                                                    </select>
 
-                                                    <label for="sex-none" class="radio inline"><span class="patronsex-none">None specified:</span></label>
-                                                    [% IF borrower.sex == '' %]
-                                                        <input type="radio" name="borrower_sex" id="sex-none" value="" checked="checked" />
-                                                    [% ELSE %]
-                                                        <input type="radio" name="borrower_sex" id="sex-none" value="" />
+                                                    [% IF mandatory.sex %]
+                                                        <div class="required_label required" style="margin-top: 0.4em;">Required</div>
                                                     [% END %]
                                                 </li>
                                             [% END %]