gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 30058: Add Koha::Patrons->filter_by_have_subpermission 

This method will allow to filter a patron set by a given subpermission.
It will be useful on bug 30055 where we want to display only patron
with suggestion or acquisition subpermission.
Note that it could be extended to allow several subpermissions, but we
don't need it so far.

Test plan:
  prove t/db_dependent/Koha/Patrons.t
must return green

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Jonathan Druart 2022-02-09 13:41:47 +01:00 committed by Fridolin Somers
parent 174adb2a3b
commit 9c6741cbe3
2 changed files with 116 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
Koha/Patrons.pm
View File

@ -520,6 +520,45 @@ sub filter_by_amount_owed {
return $self->search( $where, $attrs );
}
=head3 filter_by_have_subpermission
my $patrons = Koha::Patrons->search->filter_by_have_subpermission('suggestions.suggestions_manage');
Filter patrons who have a given subpermission
=cut
sub filter_by_have_subpermission {
my ($self, $subpermission) = @_;
my ($p, $sp) = split '\.', $subpermission;
my $perm = Koha::Database->new()->schema()->resultset('Userflag')->find({flag => $p});
Koha::Exceptions::ObjectNotFound->throw( sprintf( "Permission %s not found", $p ) )
unless $perm;
my $bit = $perm->bit;
return $self->search(
{
-and => [
-or => [
\"me.flags & (1 << $bit)",
{ 'me.flags' => 1 },
{
-and => [
{ 'user_permissions.module_bit' => $bit },
{ 'user_permissions.code' => $sp }
]
}
]
]
},
{ prefetch => 'user_permissions' }
);
}
=head3 _type
=cut

78
t/db_dependent/Koha/Patrons.t
View File

@ -19,7 +19,7 @@
use Modern::Perl;
use Test::More tests => 43;
use Test::More tests => 44;
use Test::Warn;
use Test::Exception;
use Test::MockModule;
@ -2346,4 +2346,80 @@ subtest 'filter_by_amount_owed' => sub {
};
subtest 'filter_by_have_subpermission' => sub {
plan tests => 4;
$schema->storage->txn_begin;
my $library = $builder->build_object( { class => 'Koha::Libraries' } );
my $patron_1 = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 1, branchcode => $library->branchcode }
}
);
my $patron_2 = $builder->build_object( # 4096 = 1 << 12 for suggestions
{
class => 'Koha::Patrons',
value => { flags => 4096, branchcode => $library->branchcode }
}
);
my $patron_3 = $builder->build_object(
{
class => 'Koha::Patrons',
value => { flags => 0, branchcode => $library->branchcode }
}
);
$builder->build(
{
source => 'UserPermission',
value => {
borrowernumber => $patron_3->borrowernumber,
module_bit => 11,
code => 'order_manage',
},
}
);
is_deeply(
[
Koha::Patrons->search( { branchcode => $library->branchcode } )
->filter_by_have_subpermission('suggestions.suggestions_manage')
->get_column('borrowernumber')
],
[ $patron_1->borrowernumber, $patron_2->borrowernumber ],
'Superlibrarian and patron with suggestions.suggestions_manage'
);
is_deeply(
[
Koha::Patrons->search( { branchcode => $library->branchcode } )
->filter_by_have_subpermission('acquisition.order_manage')
->get_column('borrowernumber')
],
[ $patron_1->borrowernumber, $patron_3->borrowernumber ],
'Superlibrarian and patron with acquisition.order_manage'
);
is_deeply(
[
Koha::Patrons->search( { branchcode => $library->branchcode } )
->filter_by_have_subpermission('parameters.manage_cities')
->get_column('borrowernumber')
],
[ $patron_1->borrowernumber ],
'Only Superlibrarian is returned'
);
throws_ok {
Koha::Patrons->search( { branchcode => $library->branchcode } )
->filter_by_have_subpermission('dont_exist.subperm');
} 'Koha::Exceptions::ObjectNotFound';
$schema->storage->txn_rollback;
};
$schema->storage->txn_rollback;