gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 15503 [QA Followup] - Use Koha::AuthorisedValues and fetch notforloan values. 

Signed-off-by: Benjamin Daeuber <bdaeuber@cityoffargo.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Matthias Meusburger 2016-12-12 16:11:08 +00:00 committed by Kyle M Hall
parent 73ec9a075a
commit 9b13e06275
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
acqui/addorderiso2709.pl
View File

@ -467,8 +467,9 @@ sub import_biblios_list {
my @list = ();
my $item_error = 0;
my $ccodes = GetKohaAuthorisedValues("items.ccode");
my $locations = GetKohaAuthorisedValues("items.location");
my $ccodes = { map { $_->{authorised_value} => $_->{opac_description} } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.ccode' } ) };
my $locations = { map { $_->{authorised_value} => $_->{opac_description} } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.location' } ) };
my $notforloans = { map { $_->{authorised_value} => $_->{lib} } Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '', kohafield => 'items.notforloan' } ) };
# location list
my @locations;
foreach (sort keys %$locations) {
@ -478,7 +479,10 @@ sub import_biblios_list {
foreach (sort {$ccodes->{$a} cmp $ccodes->{$b}} keys %$ccodes) {
push @ccodes, { code => $_, description => $ccodes->{$_} };
}
my @notforloans;
foreach (sort {$notforloans->{$a} cmp $notforloans->{$b}} keys %$notforloans) {
push @notforloans, { code => $_, description => $notforloans->{$_} };
}
my $biblio_count = 0;
foreach my $biblio (@$biblios) {
@ -607,6 +611,7 @@ sub import_biblios_list {
locationloop => \@locations,
itypeloop => \@itypes,
ccodeloop => \@ccodes,
notforloanloop => \@notforloans,
);
batch_info($template, $batch);
}

12
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
View File

@ -370,7 +370,17 @@
</select>
</li>
<li><label for="notforloan_item_[% item.item_id %]">notforloan</label><input type="text" id="notforloan_item_[% item.item_id %]" name="notforloan_[% item.biblio_count %]" value="[% item.notforloan %]"></li>
<li>
<label for="notforloan_item_[% item.item_id %]">notforloan</label><select id="notforloan_item_[% item.item_id %]" name="notforloan_[% item.biblio_count %]">
[% FOREACH n IN notforloanloop %]
[% IF n.code == item.notforloan %]
<option value="[% n.code %]" selected="selected">[% n.description %]</option>
[% ELSE %]
<option value="[% n.code %]">[% n.description %]</option>
[% END %]
[% END %]
</select>
</li>
<li><label for="uri_item_[% item.item_id %]">uri</label><input type="text" id="uri_item_[% item.item_id %]" name="uri_[% item.biblio_count %]" value="[% item.uri %]"></li>
<li><label for="copyno_item_[% item.item_id %]">copyno</label><input type="text" id="copyno_item_[% item.item_id %]" name="copyno_[% item.biblio_count %]" value="[% item.copyno %]"></li>
<li><label for="budget_code_item_[% item.item_id %]">budget_code</label><select id="budget_code_item_[% item.item_id %]" name="budget_code_[% item.biblio_count %]">