gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 13178: increase max value of CardnumberLength 

testplan
1 - Apply patch
2 - Run updatedatabase.pl
3 - Update dbix scheme
4 - set the value of CardnumberLength to a value between 16 and 32
5 - Check you can enter a propper cardnumber
(modify to 32 instead 20)

+ max value now depends on the database field value to

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Baptiste Wojtkowski 2017-06-19 15:04:28 +00:00 committed by Jonathan Druart
parent d25719d223
commit 99caf5329b
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
C4/Members.pm
View File

@ -896,7 +896,7 @@ database column.
=cut
sub get_cardnumber_length {
my ( $min, $max ) = ( 0, 16 ); # borrowers.cardnumber is a nullable varchar(16)
my ( $min, $max ) = ( 0, 32 ); # borrowers.cardnumber is a nullable varchar(20)
$min = 1 if C4::Context->preference('BorrowerMandatoryField') =~ /cardnumber/;
if ( my $cardnumber_length = C4::Context->preference('CardnumberLength') ) {
# Is integer and length match

6
installer/data/mysql/atomicupdate/bug_13178_wide_cardnumber.sql Normal file
View File

@ -0,0 +1,6 @@
ALTER TABLE borrowers MODIFY cardnumber varchar(32);
ALTER TABLE borrower_modifications MODIFY cardnumber varchar(32);
ALTER TABLE deletedborrowers MODIFY cardnumber varchar(32);
ALTER TABLE deletedborrowers MODIFY cardnumber varchar(32);
ALTER TABLE pending_offline_operations MODIFY cardnumber varchar(32);
ALTER TABLE tmp_holdsqueue MODIFY cardnumber varchar(32);