gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Bug 28503: Unit tests" 

This reverts commit 77515dbb4d.
This commit is contained in:
Fridolin Somers 2021-06-22 14:21:22 +02:00
parent 2855b167a0
commit 997f5a9f47
2 changed files with 2 additions and 65 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
misc/cronjobs/update_patrons_category.pl
View File

@ -47,7 +47,6 @@ update_patrons_category.pl -f=categorycode -t=categorycode
update_patrons_category.pl --help | --man
Options:
--help brief help message
--man full documentation
-too_old update if over maximum age for current category

66
t/db_dependent/Reserves.t
View File

@ -1076,9 +1076,9 @@ subtest 'RevertWaitingStatus' => sub {
);
};
subtest 'CheckReserves additional tests' => sub {
subtest 'CheckReserves additional test' => sub {
plan tests => 8;
plan tests => 3;
my $item = $builder->build_sample_item;
my $reserve1 = $builder->build_object(
@ -1151,68 +1151,6 @@ subtest 'CheckReserves additional tests' => sub {
is( $matched_reserve->{reserve_id},
$reserve1->reserve_id, "We got the Transit reserve" );
is( scalar @$possible_reserves, 2, 'We do get both reserves' );
my $patron_B = $builder->build_object({ class => "Koha::Patrons" });
my $item_A = $builder->build_sample_item;
my $item_B = $builder->build_sample_item({
homebranch => $patron_B->branchcode,
biblionumber => $item_A->biblionumber,
itype => $item_A->itype
});
Koha::CirculationRules->set_rules(
{
branchcode => undef,
categorycode => undef,
itemtype => $item_A->itype,
rules => {
reservesallowed => 25,
holds_per_record => 1,
}
}
);
Koha::CirculationRules->set_rule({
branchcode => undef,
itemtype => $item_A->itype,
rule_name => 'holdallowed',
rule_value => 'from_home_library'
});
my $reserve_id = AddReserve(
{
branchcode => $patron_B->branchcode,
borrowernumber => $patron_B->borrowernumber,
biblionumber => $item_A->biblionumber,
priority => 1,
itemnumber => undef,
}
);
ok( $reserve_id, "We can place a record level hold because one item is owned by patron's home library");
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary');
( $status, $matched_reserve, $possible_reserves ) = CheckReserves( $item_A->itemnumber );
is( $status, "", "We do not fill the hold with item A because it is not from the patron's homebranch");
Koha::CirculationRules->set_rule({
branchcode => $item_A->homebranch,
itemtype => $item_A->itype,
rule_name => 'holdallowed',
rule_value => 'from_any_library'
});
( $status, $matched_reserve, $possible_reserves ) = CheckReserves( $item_A->itemnumber );
is( $status, "Reserved", "We fill the hold with item A because item's branch rule says allow any");
# Changing the control branch should change only the rule we get
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary');
( $status, $matched_reserve, $possible_reserves ) = CheckReserves( $item_A->itemnumber );
is( $status, "", "We do not fill the hold with item A because it is not from the patron's homebranch");
Koha::CirculationRules->set_rule({
branchcode => $patron_B->branchcode,
itemtype => $item_A->itype,
rule_name => 'holdallowed',
rule_value => 'from_any_library'
});
( $status, $matched_reserve, $possible_reserves ) = CheckReserves( $item_A->itemnumber );
is( $status, "Reserved", "We fill the hold with item A because patron's branch rule says allow any");
};
subtest 'AllowHoldOnPatronPossession test' => sub {