gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194 

If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high.

This is corrected by a better test of the hash value in the CheckVersionPref subroutine.

Test plan:
[1] Create a small pref file and remove the version pref (if present). You
could for instance do a pref backup and remove most lines.
[2] Use the restore option with and without this patch.
    So, something like:
        maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f 9999crucial.pref
[3] Check on the error message and the pref count.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
This commit is contained in:
Marcel de Rooy 2014-10-06 14:09:53 +02:00 committed by Tomas Cohen Arazi
parent 4f6d1c7ae2
commit 98a3aa4d8f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
misc/maintenance/cmp_sysprefs.pl
View File

@ -234,7 +234,7 @@ sub DeleteOnePref {
sub CheckVersionPref { #additional precaution
#if there are versions, compare them
my ($hash) = @_;
my $hv = $hash->{version}->{value};
my $hv = exists $hash->{version}? $hash->{version}->{value}: undef;
return if !defined $hv;
my ($dv) = $dbh->selectrow_array(
'SELECT value FROM systempreferences