gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 22118: Format hold fee when placing holds in OPAC 

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

Signed-off-by: Jack Kelliher <jke0429@stacmail.net>
Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4f0618a888)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit b8527c5057)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Katrin Fischer 2019-01-12 09:21:38 +01:00 committed by Lucas Gass
parent 0451ac7f66
commit 9880c7d852
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt
View File

@ -129,9 +129,9 @@
[% IF (RESERVE_CHARGE) %]
<div class="alert" id="reserve_fee">
[% IF Koha.Preference('HoldFeeMode') == 'any_time_is_collected' %]
You will be charged a hold fee of [% RESERVE_CHARGE %] when you collect this item
You will be charged a hold fee of [% RESERVE_CHARGE | $Price %] when you collect this item
[% ELSE %]
You will be charged a hold fee of [% RESERVE_CHARGE %] for placing this hold
You will be charged a hold fee of [% RESERVE_CHARGE | $Price %] for placing this hold
[% END %]
</div>
[% END %]

2
opac/opac-reserve.pl
View File

@ -101,7 +101,7 @@ if ( $patron->category->effective_BlockExpiredPatronOpacActions ) {
# Pass through any reserve charge
my $reservefee = $patron->category->reservefee;
if ( $reservefee > 0){
$template->param( RESERVE_CHARGE => sprintf("%.2f",$reservefee));
$template->param( RESERVE_CHARGE => $reservefee);
}
my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } };