Bug 36453: (QA follow-up) Cosmetic fixes

This is a squash of several improvements:
- Override weird blue color being applied from MultipleSelect when all options from an optgroup are selected;
- Fix input width depending on selected value. Now it should always be same width regardless;
- Updated the system preference UI wording to reflect new behavior;
- Updated UI labels in the patron category edit page to enforce that the actions being selected are "actions to be blocked"
- Corrected sysprefs.sql entry

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

installer/data/mysql/mandatory/sysprefs.sql

@@ -117,7 +117,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
 ('BiblioDefaultView','normal','normal|marc|isbd','Choose the default detail view in the catalog; choose between normal, marc or isbd','Choice'),
 ('BiblioItemtypeInfo','0','0','Control which itemtype info displays for biblio level itemtypes','YesNo'),
 ('BibtexExportAdditionalFields',  '', NULL ,  'Define additional BibTex tags to export from MARC records in YAML format as an associative array with either a marc tag/subfield combination as the value, or a list of tag/subfield combinations.',  'textarea'),
-('BlockExpiredPatronOpacActions','','hold,renew','Specific actions expired patrons of this category are blocked from performing or if the BlockExpiredPatronOpacActions system preference is to be followed','multiple'),
+('BlockExpiredPatronOpacActions','','hold,renew','Specific actions expired patrons of this category are blocked from performing. OPAC actions blocked based on the patron category take priority over this preference.','multiple'),
 ('BlockReturnOfLostItems','0','0','If enabled, items that are marked as lost cannot be returned.','YesNo'),
 ('BlockReturnOfWithdrawnItems','1','0','If enabled, items that are marked as withdrawn cannot be returned.','YesNo'),
 ('BorrowerMandatoryField','surname|cardnumber',NULL,'Choose the mandatory fields for a patron\'s account','free'),

koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss

@@ -179,6 +179,11 @@ fieldset {
                         width:auto;
                     }
                 }
+
+                ul>li.hide-radio.selected {
+                    color: initial;
+                    background-color: initial;
+                }
             }
         }
 

koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt

@@ -341,16 +341,16 @@
                       [% END %]
                     </select>
                 </li>
-                <li><label for="block_expired">Block expired patrons actions:</label>
+                <li><label for="block_expired">Block expired patron OPAC actions:</label>
                     <select name="BlockExpiredPatronOpacActions" id="block_expired" multiple="multiple">
                         <optgroup label="Follow system preference">
-                        [% IF not category or category.BlockExpiredPatronOpacActions_contains('follow_syspref_BlockExpiredPatronOpacActions') %]
-                            <option value="follow_syspref_BlockExpiredPatronOpacActions" selected="selected"> Follow system preference BlockExpiredPatronOpacActions </option>
+                        [% IF category and category.BlockExpiredPatronOpacActions_contains('follow_syspref_BlockExpiredPatronOpacActions') %]
+                            <option value="follow_syspref_BlockExpiredPatronOpacActions" selected="selected"> Block actions specified in BlockExpiredPatronOpacActions </option>
                         [% ELSE %]
-                            <option value="follow_syspref_BlockExpiredPatronOpacActions"> BlockExpiredPatronOpacActions </option>
+                            <option value="follow_syspref_BlockExpiredPatronOpacActions"> Block actions in BlockExpiredPatronOpacActions </option>
                         [% END %]
                         </optgroup>
-                        <optgroup label="Specific actions">
+                        <optgroup label="Block specific actions">
                         [% IF category and category.BlockExpiredPatronOpacActions_contains('hold') %]
                             <option value="hold" selected="selected"> Placing a hold on an item </option>
                         [% ELSE %]
@@ -364,8 +364,7 @@
                         </optgroup>
                     </select>
                     <div class="hint">
-                        Choose whether patrons of this category be blocked from public catalog actions such as renewing and placing holds when their cards have expired.
-                    </div>
+                        Choose which OPAC actions, if any, are blocked for expired patrons of this category. Alternatively, the system preference <a href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=BlockExpiredPatronOpacActions">BlockExpiredPatronOpacActions</a> can be used instead.
                 </li>
                 [% IF ( Koha.Preference('CheckPrevCheckout') == 'softyes' || Koha.Preference('CheckPrevCheckout') == 'softno' )  %]
                   <li><label for="checkprevcheckout">Check for previous checkouts: </label>

koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref

@@ -640,11 +640,12 @@ OPAC:
                   1: Allow
             - "OPAC users to share private lists with other patrons."
         -
+            - "Expired patrons are blocked from performing the following actions in the OPAC:"
             - pref: BlockExpiredPatronOpacActions
               multiple:
                   renew: "Renewing an item"
                   hold: "Placing a hold on an item"
-            - expired patrons from OPAC actions such as placing a hold or renewing. Note that the setting for a patron category takes priority over this system preference.
+            - "<p>Please note: OPAC actions blocked based on the patron category take priority over this preference.</p>"
         -
             - The cleanup_database.pl cronjob automatically deletes unaccepted private list share invites after
             - pref: PurgeListShareInvitesOlderThan