Bug 41001: Remove messages when dialog closes, even if not through the close button
This ensures that when the dialog is closed, even when clicked outside of it, the messages are correctly removed, same as if the 'close' button had been clicked.
Test plan:
- create a data ERM provider /cgi-bin/koha/erm/eusage/usage_data_providers/add
- dummy data should be sufficient
- then go to data providers list /cgi-bin/koha/erm/eusage/usage_data_provider
- open web development tools console (F12 firefox)
- click on "Run now"
- dismiss dialog by clicking outside the modal!
- click again on "Run now"
- check the logs for errors
- any other clicks to create a modal won't work now ("run now", "delete")
Apply patch. run yarn js:watch or yarn js:build. Repeat.
Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
(cherry picked from commit 3908b7bc1c)
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
This commit is contained in:
parent
9440c4adfe
commit
96d2d5da9a
|
|
@ -164,9 +164,12 @@ export default {
|
|||
return
|
||||
}
|
||||
nextTick(() => {
|
||||
$("#warning.modal").modal("show")
|
||||
})
|
||||
})
|
||||
$("#warning.modal").on("hidden.bs.modal", function () {
|
||||
removeMessages();
|
||||
});
|
||||
$("#warning.modal").modal("show");
|
||||
});
|
||||
});
|
||||
|
||||
watch(confirmation, newConfirmation => {
|
||||
if (!newConfirmation) {
|
||||
|
|
@ -174,9 +177,12 @@ export default {
|
|||
return
|
||||
}
|
||||
nextTick(() => {
|
||||
$("#confirmation.modal").modal("show")
|
||||
})
|
||||
})
|
||||
$("#confirmation.modal").on("hidden.bs.modal", function () {
|
||||
removeConfirmationMessages();
|
||||
});
|
||||
$("#confirmation.modal").modal("show");
|
||||
});
|
||||
});
|
||||
|
||||
return {
|
||||
message,
|
||||
|
|
|
|||
Loading…
Reference in New Issue