Bug 42764: Include filename in codespell test output
Without a test comment, failures appear as bare 'not ok N' lines with no indication of which file failed or what codespell found. Passing the filename as the third argument to is() means: - Every passing test shows: ok N - path/to/file - Every failing test shows: not ok N - path/to/file Test plan: 1. Apply patch 2. Introduce a deliberate spelling error in any .pl file 3. prove xt/author/codespell.t => Failing line shows the filename and the codespell finding inline, without needing to dig into full console logs Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
parent
e7dc04a178
commit
952e60e221
|
|
@ -25,7 +25,7 @@ my %results;
|
|||
for my $file (@files) {
|
||||
my $output = qx{codespell -d --ignore-words .codespell-ignore $file};
|
||||
chomp $output;
|
||||
is( $output, q{} ) or $results{$file} = 1;
|
||||
is( $output, q{}, $file ) or $results{$file} = 1;
|
||||
}
|
||||
|
||||
$ci->report_results( \%results );
|
||||
|
|
|
|||
Loading…
Reference in New Issue