gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 18393: Acquisition statistics - Fix wrong template variable name for collection filter 

The template variable was wrong, so the filter never submitted the
collection code for the query.

Before:
<option value="">Fiction</option>
<option value="">Non-fiction</option>

After:
<option value="FIC">Fiction</option>
<option value="NFIC">Non-fiction</option>

To test:
- Go to Reports > Statistics wizards > Acquisitions
- Pick a row and column
- Compare results with and without collection filter
- Verify the table is always the same
- Apply patch
- Repeat comparison, verify the filter works now

https://bugs.koha-community.org/show_bug.cgi?id=18393
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit f2746dd8fb)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Katrin Fischer 2019-02-06 11:43:52 +00:00 committed by Martin Renvoize
parent 97f41c827f
commit 9523546f2d
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt
View File

@ -175,7 +175,7 @@
<select name="Filter">
<option value="" selected="selected">All</option>
[% FOREACH ccode_av IN ccode_avlist %]
<option value="[% ccode_av.value | html %]">[% ccode_av.lib | html %]</option>
<option value="[% ccode_av.authorised_value | html %]">[% ccode_av.lib | html %]</option>
[% END %]
</select>
[% ELSE %]