gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug #6142 - Delete sub CanBookBeReserved and delete function's reference on @EXPORT 

Original-Author:    Alex Arnaud <alex.arnaud@biblibre.com>, Stéphane Delaune <stephane.delaune@biblibre.com>
Original-Signed-off-by: MJ Ray <mjr@phonecoop.coop>

Correct use statement bug found by Ian Walls

Backporting to 3.6.x

Author: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This commit is contained in:
Alex Arnaud 2011-04-08 14:02:19 +02:00 committed by Chris Nighswonger
parent b053896895
commit 93cb222de2
1 changed files with 3 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
C4/ILSDI/Utility.pm
View File

@ -1,6 +1,7 @@
package C4::ILSDI::Utility;
# Copyright 2009 SARL Biblibre
# Copyright 2011 software.coop and MJ Ray
#
# This file is part of Koha.
#
@ -24,7 +25,7 @@ use C4::Members;
use C4::Items;
use C4::Circulation;
use C4::Biblio;
use C4::Reserves qw(GetReservesFromBorrowernumber);
use C4::Reserves qw(GetReservesFromBorrowernumber CanBookBeReserved);
use C4::Context;
use C4::Branch qw/GetBranchName/;
use Digest::MD5 qw(md5_base64);
@ -38,7 +39,7 @@ BEGIN {
require Exporter;
@ISA = qw(Exporter);
@EXPORT = qw(
&BorrowerExists &CanBookBeReserved &Availability
&BorrowerExists &Availability
);
}
@ -67,55 +68,6 @@ sub BorrowerExists {
return $sth->fetchrow;
}
=head2 CanBookBeReserved
Checks if a book (at bibliographic level) can be reserved by a borrower.
if ( CanBookBeReserved($borrower, $biblionumber) ) {
# Do stuff
}
=cut
sub CanBookBeReserved {
my ( $borrower, $biblionumber ) = @_;
my $MAXIMUM_NUMBER_OF_RESERVES = C4::Context->preference("maxreserves");
my $MAXOUTSTANDING = C4::Context->preference("maxoutstanding");
my $out = 1;
if ( $borrower->{'amountoutstanding'} > $MAXOUTSTANDING ) {
$out = undef;
}
if ( $borrower->{gonenoaddress} eq 1 ) {
$out = undef;
}
if ( $borrower->{lost} eq 1 ) {
$out = undef;
}
if ( $borrower->{debarred} eq 1 ) {
$out = undef;
}
my @reserves = GetReservesFromBorrowernumber( $borrower->{'borrowernumber'} );
if ( $MAXIMUM_NUMBER_OF_RESERVES && scalar(@reserves) >= $MAXIMUM_NUMBER_OF_RESERVES ) {
$out = undef;
}
foreach my $res (@reserves) {
if ( $res->{'biblionumber'} == $biblionumber ) {
$out = undef;
}
}
my $issues = GetPendingIssues( $borrower->{'borrowernumber'} );
foreach my $issue (@$issues) {
if ( $issue->{'biblionumber'} == $biblionumber ) {
$out = undef;
}
}
return $out;
}
=head2 Availability
Returns, for an itemnumber, an array containing availability information.