Bug 29605: account_offsets.type is not null

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

installer/data/mysql/atomicupdate/bug_29605.pl

@@ -32,8 +32,17 @@ return {
                 ADD CONSTRAINT `tmp_holdsqueue_ibfk_3` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE
             });
 
-            say $out "Added missing foreign key on tmp_holdsqueue"
+            say $out "Added missing foreign key on tmp_holdsqueue";
         }
 
+        $dbh->do(
+            q{
+                ALTER TABLE `account_offsets`
+                MODIFY COLUMN `type` enum( 'CREATE', 'APPLY', 'VOID', 'OVERDUE_INCREASE', 'OVERDUE_DECREASE' ) NOT NULL
+            }
+        );
+        say $out "Ensure NOT NULL on account_offsets.type";
+
     },
+
 }

installer/data/mysql/db_revs/210600013.pl

@@ -34,7 +34,7 @@ return {
                         'VOID',
                         'OVERDUE_INCREASE',
                         'OVERDUE_DECREASE'
-                    )
+                    ) NOT NULL
                 AFTER `debit_id`
               }
         );