gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

followup - make barcode_to_borrowernumber an internal function 

Set this function apart with _ since it is not OO like the rest.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
This commit is contained in:
Joe Atzberger (siptest 2008-11-04 14:34:52 -06:00 committed by Galen Charlton
parent f4d902a76c
commit 8c2e5cc3aa
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
C4/SIP/ILS/Item.pm
View File

@ -234,10 +234,10 @@ sub available {
return 0;
}
sub barcode_to_borrowernumber ($) {
sub _barcode_to_borrowernumber ($) {
my $known = shift;
(defined($known)) or return undef;
my $member = GetMember($known, 'cardnumber') or return undef; # borrowernumber is default type for GetMember lookup
my $member = GetMember($known,'cardnumber') or return undef;
return $member->{borrowernumber};
}
sub barcode_is_borrowernumber ($$$) { # because hold_queue only has borrowernumber...
@ -245,7 +245,7 @@ sub barcode_is_borrowernumber ($$$) { # because hold_queue only has borrowern
my $barcode = shift;
my $number = shift or return undef; # can't be zero
(defined($barcode)) or return undef; # might be 0 or 000 or 000000
my $converted = barcode_to_borrowernumber($barcode) or return undef;
my $converted = _barcode_to_borrowernumber($barcode) or return undef;
return ($number eq $converted); # even though both *should* be numbers, eq is safer.
}
1;