gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20724: Add tests for ReservesNeedReturns 

Signed-off-by: Victor Grousset <victor.grousset@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2018-05-10 11:40:33 -03:00
parent 1798d22e76
commit 8b6dc6b23c
1 changed files with 55 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
t/db_dependent/Reserves.t
View File

@ -17,7 +17,7 @@
use Modern::Perl;
use Test::More tests => 56;
use Test::More tests => 57;
use Test::MockModule;
use Test::Warn;
@ -54,6 +54,9 @@ my $builder = t::lib::TestBuilder->new;
my $frameworkcode = q||;
t::lib::Mocks::mock_preference('ReservesNeedReturns', 1);
# Somewhat arbitrary field chosen for age restriction unit tests. Must be added to db before the framework is cached
$dbh->do("update marc_subfield_structure set kohafield='biblioitems.agerestriction' where tagfield='521' and tagsubfield='a' and frameworkcode=?", undef, $frameworkcode);
my $cache = Koha::Caches->get_instance;
@ -668,6 +671,57 @@ subtest '_koha_notify_reserve() tests' => sub {
};
subtest 'ReservesNeedReturns' => sub {
plan tests => 4;
my $biblioitem = $builder->build_object( { class => 'Koha::Biblioitems' } );
my $library = $builder->build_object( { class => 'Koha::Libraries' } );
my $itemtype = $builder->build_object( { class => 'Koha::ItemTypes', value => { rentalcharge => 0 } } );
my $item_info = {
biblionumber => $biblioitem->biblionumber,
biblioitemnumber => $biblioitem->biblioitemnumber,
homebranch => $library->branchcode,
holdingbranch => $library->branchcode,
itype => $itemtype->itemtype,
};
my $item = $builder->build_object( { class => 'Koha::Items', value => $item_info } );
my $patron = $builder->build_object(
{
class => 'Koha::Patrons',
value => { branchcode => $library->branchcode, }
}
);
my $priority = 1;
my ( $hold_id, $hold );
t::lib::Mocks::mock_preference('ReservesNeedReturns', 0); # '0' means 'Automatically mark a hold as found and waiting'
$hold_id = C4::Reserves::AddReserve(
$library->branchcode, $patron->borrowernumber,
$item->biblionumber, '',
$priority, undef,
undef, '',
"title for fee", $item->itemnumber,
);
$hold = Koha::Holds->find($hold_id);
is( $hold->priority, 0, 'If ReservesNeedReturns is 0, priority must have been set to 0' );
is( $hold->found, 'W', 'If ReservesNeedReturns is 0, found must have been set waiting' );
$hold->delete; # cleanup
t::lib::Mocks::mock_preference('ReservesNeedReturns', 1); # '0' means "Don't automatically mark a hold as found and waiting"
$hold_id = C4::Reserves::AddReserve(
$library->branchcode, $patron->borrowernumber,
$item->biblionumber, '',
$priority, undef,
undef, '',
"title for fee", $item->itemnumber,
);
$hold = Koha::Holds->find($hold_id);
is( $hold->priority, $priority, 'If ReservesNeedReturns is 1, priority must not have been set to changed' );
is( $hold->found, undef, 'If ReservesNeedReturns is 1, found must not have been set waiting' );
};
sub count_hold_print_messages {
my $message_count = $dbh->selectall_arrayref(q{
SELECT COUNT(*)