gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 34647: Replace name attributes with ids 

This patch replaces name attributes on <a> tags as this is now obsolete
in HTML 5. The recommended practice is to substitute these for ids, as
has been done in this patch

Test plan:
1) Navigate to each page where the link has been amended
2) Check that the link still works as expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Matt Blenkinsop 2024-01-24 15:08:56 +00:00 committed by Katrin Fischer
parent f931a0ac80
commit 8a07455e3b
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
View File

@ -79,7 +79,7 @@
[% ELSE %]
<h2 class="suppliername inactive">
[% END %]
<a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]">
<a id="vendor[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]">
[% IF (supplier.name) %]
[% supplier.name | html %]
[% ELSE %]

4
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
View File

@ -243,7 +243,7 @@
</td>
<td>
[% IF note.defined && note != '' %]
<a name="viewnote" data-toggle="popover" title="Note" data-content="[% note | html %]" data-placement="top" data-trigger="hover">View note</a>
<a id="viewnote" data-toggle="popover" title="Note" data-content="[% note | html %]" data-placement="top" data-trigger="hover">View note</a>
[% ELSE %]<span>&nbsp;</span>[% END %]
</td>
<td>
@ -1497,7 +1497,7 @@
var current_column = $("#edit_row td:eq("+i+")");
if ( i == 3 ) {
// specific processing for the Note column
var note = $(this).find("a[name='viewnote']").data("content");
var note = $(this).find("a[id='viewnote']").data("content");
$(current_column).find("input[type='text']").val(note);
} else if ( i == 9 ) {
// specific processing for Hard due date

2
koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
View File

@ -81,7 +81,7 @@
[% IF ( mainloo.looptables ) %]
<div class="page-section">
<h3><a name="summary" id="summary"></a>Summary</h3>
<h3><a id="summary"></a>Summary</h3>
<table id="summary_table">
<tr>
<th>Group</th>

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
View File

@ -94,7 +94,7 @@
[% IF ( news_item ) %]
[% koha_new.title | html %]
[% ELSE %]
<a name="newsitem[% koha_new.id | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.id | uri %]">[% koha_new.title | html %]</a>
<a id="newsitem[% koha_new.id | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.id | uri %]">[% koha_new.title | html %]</a>
[% END %]
</h4>
<div class="newsbody">[% koha_new.content | $raw %]</div>

2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
View File

@ -978,7 +978,7 @@
<ol class="attributes_table">
[% FOREACH pa IN pa_class.items %]
[% FOREACH pa_value IN pa.values %]
[% IF loop.first %]<a name="patron-attr-start-[% pa.type.code | html %]"></a>[% END %]
[% IF loop.first %]<a id="patron-attr-start-[% pa.type.code | html %]"></a>[% END %]
[% form_id = 'patron-attr-' _ Math.int( Math.rand(1000000) ) %]
<li data-category_code="[% pa.type.category_code | html %]">
[% IF pa.type.mandatory && pa.type.opac_editable %]