Bug 25223: Make join of aqbasket and aqorders explicit
This is simply a SQL change that makes things a bit easier to read
and also prevents too much data being returned in a large system
To test:
1 - Have some orders in your system in the ordered status
2 - Click the 'Ordered' amount for your budget from Acquisitions home
3 - Note the view of orders, possibly screen shot
4 - Apply patch
5 - Restart all the things
6 - Reload the ordered page
7 - Confirm nothing has changed
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 7d69c0f10c)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
parent
79da96c9d2
commit
896f4bcf24
|
|
@ -60,7 +60,8 @@ SELECT
|
|||
aqbooksellers.name as vendorname,
|
||||
GROUP_CONCAT(DISTINCT itype SEPARATOR '|') AS itypes,
|
||||
title
|
||||
FROM (aqorders, aqbasket)
|
||||
FROM aqorders
|
||||
JOIN aqbasket USING (basketno)
|
||||
LEFT JOIN biblio ON
|
||||
biblio.biblionumber=aqorders.biblionumber
|
||||
LEFT JOIN aqorders_items ON
|
||||
|
|
@ -70,7 +71,6 @@ LEFT JOIN items ON
|
|||
LEFT JOIN aqbooksellers ON
|
||||
aqbasket.booksellerid = aqbooksellers.id
|
||||
WHERE
|
||||
aqorders.basketno=aqbasket.basketno AND
|
||||
budget_id=? AND
|
||||
(datecancellationprinted IS NULL OR
|
||||
datecancellationprinted='0000-00-00') AND
|
||||
|
|
|
|||
Loading…
Reference in New Issue