From 88da97fb0e28b53133cb076715768ee8585b7301 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 9 Jan 2025 14:30:09 +0100 Subject: [PATCH] Bug 38854: Remove 'class' property from ToolbarButton We never use another value than the default one. We can simply remove this property. Test plan: Rebuild the dist files using `yarn js:build` and confirm that the buttons in the toolbar of the ERM and Preservation modules still appears and are styled like before. Signed-off-by: William Lavoie Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer (cherry picked from commit a575d387708d3d86aeb0bda15862e8bef5289475) Signed-off-by: Paul Derscheid --- .../prog/js/vue/components/ERM/AgreementsShow.vue | 1 - .../js/vue/components/ERM/EHoldingsLocalPackagesShow.vue | 1 - .../prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue | 1 - .../prog/js/vue/components/ERM/LicensesShow.vue | 1 - .../vue/components/ERM/UsageStatisticsDataProvidersShow.vue | 1 - .../vue/components/Preservation/SettingsProcessingsShow.vue | 1 - .../prog/js/vue/components/Preservation/TrainsShow.vue | 2 -- .../intranet-tmpl/prog/js/vue/components/ToolbarButton.vue | 6 +----- 8 files changed, 1 insertion(+), 13 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue index c8330cddaa..ad6050e219 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue @@ -7,7 +7,6 @@ name: 'AgreementsFormAddEdit', params: { agreement_id: agreement.agreement_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue index 5f73b9d80d..8c949f54ae 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue @@ -7,7 +7,6 @@ name: 'EHoldingsLocalPackagesFormAddEdit', params: { package_id: erm_package.package_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue index c11003a6a3..58eedaa1d1 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue @@ -7,7 +7,6 @@ name: 'EHoldingsLocalTitlesFormAddEdit', params: { title_id: title.title_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue index 799afe24ea..6e91f7d59b 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue @@ -7,7 +7,6 @@ name: 'LicensesFormAddEdit', params: { license_id: license.license_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue index 21d46e2e70..796db87c0a 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersShow.vue @@ -10,7 +10,6 @@ usage_data_provider.erm_usage_data_provider_id, }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue index 82c35eeaf2..4c13620308 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/SettingsProcessingsShow.vue @@ -7,7 +7,6 @@ name: 'SettingsProcessingsFormEdit', params: { processing_id: processing.processing_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue index 9b3496b09d..43d369422d 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Preservation/TrainsShow.vue @@ -79,7 +79,6 @@ name: 'TrainsFormAddItem', params: { train_id: train.train_id }, }" - class="btn btn-default" icon="plus" :title="$__('Add items')" /> @@ -96,7 +95,6 @@ name: 'TrainsFormEdit', params: { train_id: train.train_id }, }" - class="btn btn-default" icon="pencil" :title="$__('Edit')" /> diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue index 4cfada715c..f44fb9d3cd 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ToolbarButton.vue @@ -1,5 +1,5 @@ @@ -10,10 +10,6 @@ export default { to: { type: [String, Object], }, - class: { - type: String, - default: "btn btn-default", - }, icon: { type: String, required: false,