Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons

Pages with DataTables' four button pagination use the wrong
icon for 'First' and 'Last'. Also, the icons for all four
buttons are truncated at the bottom.

This patch fixes that.

Test plan:
1) Go to a page that uses four button pagination (e.g. Home >
   Administration > MARC frameworks) and notice how the
   pagination icons for First/Previous and Next/Last are the
   same. Also notice all four icons are clipped at the bottom.
2) Apply the patch.
3) Refresh the page; the First and Last buttons' icons now
   include a vertical bar, and there is no clipping visible.
4) For completeness, check other affected pages as well.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 074c329774)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Andreas Roussos 2018-10-06 10:15:26 +03:00 committed by Martin Renvoize
parent 18d04888b2
commit 8802d32b7f
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
2 changed files with 7 additions and 5 deletions

View File

@ -167,7 +167,7 @@ div.dataTables_paginate.paging_four_button {
.paginate_enabled_last {
cursor: pointer;
*cursor: hand;
padding: .1em 0;
padding: .2em 0;
}
.paginate_disabled_previous,
@ -177,6 +177,8 @@ div.dataTables_paginate.paging_four_button {
color: #111 !important;
}
.paginate_disabled_first,
.paginate_enabled_first,
.paginate_disabled_previous,
.paginate_enabled_previous {
padding-left: 23px;

View File

@ -263,24 +263,24 @@ $.fn.dataTableExt.oPagination.four_button = {
var buttons = an[i].getElementsByTagName('span');
if ( oSettings._iDisplayStart === 0 )
{
buttons[0].className = "paginate_disabled_previous";
buttons[0].className = "paginate_disabled_first";
buttons[1].className = "paginate_disabled_previous";
}
else
{
buttons[0].className = "paginate_enabled_previous";
buttons[0].className = "paginate_enabled_first";
buttons[1].className = "paginate_enabled_previous";
}
if ( oSettings.fnDisplayEnd() == oSettings.fnRecordsDisplay() )
{
buttons[2].className = "paginate_disabled_next";
buttons[3].className = "paginate_disabled_next";
buttons[3].className = "paginate_disabled_last";
}
else
{
buttons[2].className = "paginate_enabled_next";
buttons[3].className = "paginate_enabled_next";
buttons[3].className = "paginate_enabled_last";
}
}
}