From 868947cb55448eefd7e3898fdde3083f4efbbd5b Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date: Fri, 22 May 2026 07:26:12 +0100
Subject: [PATCH] Bug 40901: (QA follow-up) Quote path/option values in
 koha-generate-env env files

systemd EnvironmentFile parsing treats unquoted values as ending at the
first whitespace.  PLACK_PSGIFILE and Z3950_CONFIGDIR are paths that
could in principle contain spaces; Z3950_ADDITIONAL_OPTS routinely holds
multiple flags separated by spaces (e.g. "--port 9999 --verbose").

Wrap these three values in double-quotes in the generated env file so
systemd reads the full value even when it contains spaces.

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 debian/scripts/koha-generate-env | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/scripts/koha-generate-env b/debian/scripts/koha-generate-env
index 0af2a86a49..6b908afb49 100755
--- a/debian/scripts/koha-generate-env
+++ b/debian/scripts/koha-generate-env
@@ -52,7 +52,7 @@ case "$SERVICE" in
 PLACK_WORKERS=${WORKERS:-2}
 PLACK_MAX_REQUESTS=${MAX_REQUESTS:-50}
 PLACK_ENVIRONMENT=${ENVIRONMENT}
-PLACK_PSGIFILE=${PSGIFILE}
+PLACK_PSGIFILE="${PSGIFILE}"
 EOF
         ;;
 
@@ -104,8 +104,8 @@ EOF
         fi
 
         cat > "$ENVFILE" <<EOF
-Z3950_CONFIGDIR=${CONFIGDIR}
-Z3950_ADDITIONAL_OPTS=${Z3950_OPTS}
+Z3950_CONFIGDIR="${CONFIGDIR}"
+Z3950_ADDITIONAL_OPTS="${Z3950_OPTS}"
 EOF
         ;;
 esac