From 85cc5649b5fc752d7378596a3bd5fac7d6f762e5 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 14 Mar 2025 08:40:30 +0000 Subject: [PATCH] Bug 37784: [24.05] (QA follow-up) Add few tables to Koha::Database::Columns This resolves exceptions like: Invalid table name accountlines at /usr/share/koha/C4/Reports/Guided.pm line 216. Test plan: Go to reports/dictionary.pl Try to add a new definition for Serials. Without this patch, you would crash (status 500). Run t/Koha/Database/Columns.t Signed-off-by: Marcel de Rooy Signed-off-by: Alex Buckley (cherry picked from commit d485d1f2aee159d9c400680e236d80d8483a5e7b) Signed-off-by: Fridolin Somers --- Koha/Database/Columns.pm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Koha/Database/Columns.pm b/Koha/Database/Columns.pm index 6c2c2f6c6d..e2135f976e 100644 --- a/Koha/Database/Columns.pm +++ b/Koha/Database/Columns.pm @@ -34,7 +34,8 @@ Koha::Database::Columns =head3 columns Static method that returns a hashref with mappings from column names -to descriptions, for several tables. Currently +to descriptions for several tables. +Should be extended. =over @@ -60,6 +61,14 @@ to descriptions, for several tables. Currently sub columns { return { + # TODO stub for the check in C4::Reports::Guided, get_columns (see BZ 37784) + accountlines => {}, + serial => {}, + serialitems => {}, + subscriptionhistory => {}, + subscriptionroutinglist => {}, + aqbooksellers => {}, + aqorders => { "basketno" => __("Basket ID (internal)"), "biblionumber" => __("Biblio number (internal)"),