gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 11299: (QA follow-up) Fix tests, spaces, and CSS update 

Removed my from variables in test

Undid stray line deletions

Undid adding 1; to test file

Fix CSS replace command

Update license

Fix spelling

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Nick Clemens 2020-08-21 15:47:08 +00:00 committed by Jonathan Druart
parent 11de340639
commit 85950bdbc1
4 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
C4/Biblio.pm
View File

@ -556,6 +556,7 @@ sub LinkBibHeadingsToAuthorities {
} }
require C4::Heading; require C4::Heading;
require C4::AuthoritiesMarc; require C4::AuthoritiesMarc;
$allowrelink = 1 unless defined $allowrelink; $allowrelink = 1 unless defined $allowrelink;
my $num_headings_changed = 0; my $num_headings_changed = 0;
foreach my $field ( $bib->fields() ) { foreach my $field ( $bib->fields() ) {

20
svc/cataloguing/automatic_linker.pl
View File

@ -4,18 +4,18 @@
# #
# This file is part of Koha. # This file is part of Koha.
# #
# Koha is free software; you can redistribute it and/or modify it under the # Koha is free software; you can redistribute it and/or modify it
# terms of the GNU General Public License as published by the Free Software # under the terms of the GNU General Public License as published by
# Foundation; either version 3 of the License, or (at your option) any later # the Free Software Foundation; either version 3 of the License, or
# version. # (at your option) any later version.
# #
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY # Koha is distributed in the hope that it will be useful, but
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR # WITHOUT ANY WARRANTY; without even the implied warranty of
# A PARTICULAR PURPOSE. See the GNU General Public License for more details. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# #
# You should have received a copy of the GNU General Public License along # You should have received a copy of the GNU General Public License
# with Koha; if not, write to the Free Software Foundation, Inc., # along with Koha; if not, see <http://www.gnu.org/licenses>.
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
use Modern::Perl; use Modern::Perl;
use CGI; use CGI;

1
t/Biblio.t
View File

@ -157,4 +157,3 @@ warnings_like { $ret = UpdateTotalIssues() }
"UpdateTotalIssues returns carped warnings if biblio record does not exist"; "UpdateTotalIssues returns carped warnings if biblio record does not exist";
ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist'); ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist');
1;

8
t/db_dependent/Biblio.t
View File

@ -767,13 +767,13 @@ subtest "LinkBibHeadingsToAuthorities record generation tests" => sub {
); );
#Add test for this case using verbose #Add test for this case using verbose
my ( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef, 1); ( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef, 1);
my $details = $results->{details}; my $details = $results->{details};
is( $num_headings_changed, 1, 'We changed the one we passed' ); is( $num_headings_changed, 1, 'We changed the one we passed' );
is( $results->{details}->[0]->{status}, 'CREATED', "We added an authority record for the heading using verbose"); is( $results->{details}->[0]->{status}, 'CREATED', "We added an authority record for the heading using verbose");
# Now we check the authority record itself # Now we check the authority record itself
my $authority = GetAuthority($results->{details}->[0]->{authid}); $authority = GetAuthority($results->{details}->[0]->{authid});
is( $authority->field('150')->as_string(), is( $authority->field('150')->as_string(),
"Beach city Weirdness Fiction Books 21st Century Fish Stew Pizza", "Beach city Weirdness Fiction Books 21st Century Fish Stew Pizza",
@ -800,13 +800,13 @@ subtest "LinkBibHeadingsToAuthorities record generation tests" => sub {
"The generated record contains the correct subfields" "The generated record contains the correct subfields"
); );
# The same exemple With verbose # The same example With verbose
( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef, 1); ( $num_headings_changed, $results ) = LinkBibHeadingsToAuthorities($linker, $record, "",undef, 1);
is( $num_headings_changed, 1, 'We changed the one we passed' ); is( $num_headings_changed, 1, 'We changed the one we passed' );
is( $results->{details}->[0]->{status}, 'CREATED', "We added an authority record for the heading using verbose"); is( $results->{details}->[0]->{status}, 'CREATED', "We added an authority record for the heading using verbose");
# Now we check the authority record itself # Now we check the authority record itself
my $authority = GetAuthority($results->{details}->[0]->{authid}); $authority = GetAuthority($results->{details}->[0]->{authid});
is( $authority->field('100')->as_string(), is( $authority->field('100')->as_string(),
"Tolkien, J. R. R. (John Ronald Reuel), 1892-1973. Lord of the rings", "Tolkien, J. R. R. (John Ronald Reuel), 1892-1973. Lord of the rings",
"The generated record contains the correct subfields" "The generated record contains the correct subfields"