gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 21073: (QA follow-up) Only public subs should be considered 

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Tomas Cohen Arazi 2019-06-14 16:51:07 -03:00 committed by Martin Renvoize
parent f380a06cb9
commit 81186ea269
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Koha/Plugins.pm
View File

@ -136,7 +136,7 @@ sub InstallPlugins {
Koha::Plugins::Methods->search({ plugin_class => $plugin_class })->delete();
foreach my $method ( @{ Class::Inspector->methods($plugin_class) } ) {
foreach my $method ( @{ Class::Inspector->methods( $plugin_class, 'public' ) } ) {
Koha::Plugins::Method->new(
{
plugin_class => $plugin_class,

5
t/db_dependent/Plugins.t
View File

@ -23,7 +23,7 @@ use File::Temp qw( tempdir tempfile );
use FindBin qw($Bin);
use Module::Load::Conditional qw(can_load);
use Test::MockModule;
use Test::More tests => 49;
use Test::More tests => 50;
use C4::Context;
use Koha::Database;
@ -115,6 +115,7 @@ Koha::Plugins::Methods->delete;
Koha::Plugins->new( { enable_plugins => 1 } )->InstallPlugins();
ok( Koha::Plugins::Methods->search( { plugin_class => 'Koha::Plugin::Test' } )->count, 'Test plugin methods added to database' );
is( Koha::Plugins::Methods->search({ plugin_class => 'Koha::Plugin::Test', plugin_method => '_private_sub' })->count, 0, 'Private methods are skipped' );
my $mock_plugin = Test::MockModule->new( 'Koha::Plugin::Test' );
$mock_plugin->mock( 'test_template', sub {
@ -286,4 +287,4 @@ subtest 'new() tests' => sub {
is( ref($result), 'Koha::Plugins', 'calling new with enable_plugins makes it override the config' );
};
$schema->storage->txn_rollback;
$schema->storage->txn_rollback;

4
t/lib/Koha/Plugin/Test.pm
View File

@ -182,3 +182,7 @@ sub api_routes {
return decode_json($spec);
}
sub _private_sub {
return "";
}