From 800c2df2e34bd3392d8302803e248fdf3e4f7491 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Mon, 23 Nov 2015 09:19:06 +0100 Subject: [PATCH] Bug 14599 - Saved auth login and password are used in patron creation from MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form. This behaviour is awkward from web browser. A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name I found that the best way is to use an hidden disabled input between userid and password. Test plan : - Log into Koha - Allow the browser to save the userid/password - Be sure that you have only one userid/password for this Koha - Loggout - Re log to check the browser autocomplets the authentication form - Create a new patron => Without patch your saved userid/password have been added to the form => With patch your saved userid/password have not been added to the form Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart This is not elegant but it works. Note that the problem does not exist with Chromium Signed-off-by: Kyle M Hall (cherry picked from commit f4870f6666127f0f0b2c49cc4f89cadd0241a8b9) Signed-off-by: Julian Maurice (cherry picked from commit 3f9d68e599f7e5915f8982fd199030c32c3d8cf3) Signed-off-by: Frédéric Demians --- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index a0325bb74f..2d4b23d9c3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -793,6 +793,9 @@ [% END %] [% END %] +[%# Dummy input to avoid Firefox from using userid/password saved for authentication %] + + [% IF ( mandatoryuserid ) %]Required[% END %] [%END %]