gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 32257: Label for patron attributes misaligned 

Label has now been realigned to match the format of the fields above. When
clicking to add a new field, the delete button was also misaligned. This has
 now been reformatted to sit next to the "New" button

Test Plan:
1) Navigate to Tools > Batch patron modification
2) Add either card or borrower numbers to bring up the edit patrons fields
3) "Patron attributes:" is on the far right and above the select box. When
   adding a new field there is a big gap between the Add and  Delete buttons
4) Apply patch and navigate to same area
5) Observe that the Patron attributes option is aligned to match the fields
   above and the gap between the buttons has been removed

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit d2ee603a60)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Matt Blenkinsop 2022-11-23 17:12:59 +00:00 committed by Martin Renvoize
parent 91830a27e2
commit 7e2b0163fc
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
View File

@ -368,14 +368,16 @@
[% END %]
[% IF ( patron_attributes_codes ) %]
<li class="attributes">
<label style="width:auto;">Patron attribute:
<select name="patron_attributes">
<option value=""></option>
[% FOREACH pac IN patron_attributes_codes %]
<option value="[% pac.attribute_code | html %]" data-type="[% pac.type | html %]" data-category="[% pac.category_lib | html %]">[% pac.attribute_lib | html %]</option>
[% END %]
</select>
<label style="width:auto;">
<span>Patron Attribute:</span>
</label>
<select name="patron_attributes">
<option value=""></option>
[% FOREACH pac IN patron_attributes_codes %]
<option value="[% pac.attribute_code | html %]" data-type="[% pac.type | html %]" data-category="[% pac.category_lib | html %]">[% pac.attribute_lib | html %]</option>
[% END %]
</select>
<input type="checkbox" title="check to delete this field" name="disable_input" value="attr0_value" />
<span class="patron_attributes_value"><input type"hidden" name="patron_attributes_value" /></span>
<a href="#" class="add_attributes" title="Add an attribute"><i class="fa fa-fw fa-plus"></i> New</a>
@ -543,7 +545,8 @@
var li_node = $("li.attributes:last");
var li_clone = $(li_node).clone();
if ( $(li_clone).find("a.del_attributes").length == 0 ) {
$(li_clone).append('<a href="#" title="' + _("Delete") + '" class="del_attributes"><i class="fa fa-fw fa-trash"></i> ' + _("Delete") + '</a>');
var add_attributes = $(li_clone).find("a.add_attributes")
$(add_attributes).after('<a href="#" title="' + _("Delete") + '" class="del_attributes"><i class="fa fa-fw fa-trash"></i> ' + _("Delete") + '</a>');
}
$(li_clone).find('select[name="patron_attributes"]').change(function() {
updateAttrValues(this);