gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20598: (QA follow-up) Tiny fixes 

[1] Correct POD for _FixOverduesOnReturn
Is called by AddReturn, AddRenewal and LostItem.
Also tested in Circulation.t btw

[2] $dbh is not used in _FixOverduesOnReturn
[3] Moving all parameters to the first line.
[4] Variable $uquery is not used too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 867f88076e)
(cherry picked from commit 2c77175467)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Marcel de Rooy 2018-11-16 10:37:55 +01:00 committed by Fridolin Somers
parent 0eedb1580c
commit 7e259683c8
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
C4/Circulation.pm
View File

@ -2302,22 +2302,20 @@ C<$itm> itemnumber
C<$exemptfine> BOOL -- remove overdue charge associated with this issue.
C<$dropboxmode> BOOL -- remove lastincrement on overdue charge associated with this issue.
Internal function, called only by AddReturn
Internal function
=cut
sub _FixOverduesOnReturn {
my ($borrowernumber, $item);
unless ($borrowernumber = shift) {
my ($borrowernumber, $item, $exemptfine, $dropbox ) = @_;
unless( $borrowernumber ) {
warn "_FixOverduesOnReturn() not supplied valid borrowernumber";
return;
}
unless ($item = shift) {
unless( $item ) {
warn "_FixOverduesOnReturn() not supplied valid itemnumber";
return;
}
my ($exemptfine, $dropbox) = @_;
my $dbh = C4::Context->dbh;
# check for overdue fine
my $accountline = Koha::Account::Lines->search(
@ -2332,7 +2330,6 @@ sub _FixOverduesOnReturn {
)->next();
return 0 unless $accountline; # no warning, there's just nothing to fix
my $uquery;
if ($exemptfine) {
my $amountoutstanding = $accountline->amountoutstanding;