From 7d52823ac5a596c351acedbc83ba91ca45fdc376 Mon Sep 17 00:00:00 2001
From: David Nind <david@davidnind.com>
Date: Mon, 31 Aug 2026 21:54:08 +0000
Subject: [PATCH] Bug 43432: Move ReportsExportLimit to reports category

Move the ReportsExportLimit system preference from the
staff interface category to the reports category, as
it relates only to the reports module.

1. Go to Administration > System preferences.
2. Search for the ReportsExportLimit system preference.
3. Note that it is in the Staff interface > Options category.
4. Apply the patch.
5. Repeat step 2.
6. Note that it is now in the Reports > Options category.
7. Note that the "Reports access" section is now in sentence case.

Signed-off-by: Bastien CHAUVET <bastien.chauvet@inlibro.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 .../en/modules/admin/preferences/reports.pref | 20 ++++++++++++-------
 .../admin/preferences/staff_interface.pref    |  5 -----
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/reports.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/reports.pref
index 701df654ee..5026d6304e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/reports.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/reports.pref
@@ -1,8 +1,14 @@
 Reports:
-    Reports Access:
-     -
-         - pref: LimitReportsByLibrary
-           choices:
-               1: Enable
-               0: Disable
-         - "limiting report access based on staff home library."
+    Options:
+        -
+            - Download a maximum of
+            - pref: ReportsExportLimit
+              class: integer
+            - "rows when exporting report results.<br><strong>NOTE:</strong><ul><li>Using LIMIT in a report overrides this setting.</li><li>It does not limit results for 'Open in DataTables' export options.</li></ul>"
+    Reports access:
+        -
+            - pref: LimitReportsByLibrary
+              choices:
+                  1: Enable
+                  0: Disable
+            - "limiting report access based on staff home library."
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
index 7b1d6ef49a..27edd52f36 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref
@@ -192,11 +192,6 @@ Staff interface:
                   1: Show
                   0: "Don't show"
             - a search field pulldown for 'Search the catalog' boxes.
-        -
-            - Download a maximum of
-            - pref: ReportsExportLimit
-              class: integer
-            - "rows when exporting report results.<br><strong>NOTE:</strong><ul><li>Using LIMIT in a report overrides this setting.</li><li>It does not limit results for 'Open in DataTables' export options.</li></ul>"
 
     Authentication:
         -