Bug 36917: (follow-up) Remove Elasticsearch warnings and tidy

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Nick Clemens 2024-05-22 11:52:53 +00:00 committed by Katrin Fischer
parent 1d394dcdcc
commit 7cac0105f8
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
2 changed files with 12 additions and 2 deletions

View File

@ -401,8 +401,9 @@ sub _get_search_heading {
my $field = shift;
my $subfields = shift;
my $heading = "";
my $heading = "";
return $heading unless $subfields;
my @subfields = $field->subfields();
my $first = 1;
for ( my $i = 0 ; $i <= $#subfields ; $i++ ) {
@ -439,8 +440,9 @@ sub _get_display_heading {
my $field = shift;
my $subfields = shift;
my $heading = "";
my $heading = "";
return $heading unless $subfields;
my @subfields = $field->subfields();
my $first = 1;
for ( my $i = 0 ; $i <= $#subfields ; $i++ ) {

View File

@ -28,6 +28,7 @@ BEGIN {
# Optionally change marc flavour
my $marcflavour;
GetOptions( 'flavour:s' => \$marcflavour );
$marcflavour //= 'MARC21';
t::lib::Mocks::mock_preference( 'marcflavour', $marcflavour ) if $marcflavour;
my $schema = Koha::Database->new->schema;
@ -40,6 +41,13 @@ $heading_module->mock(
return 1;
}
);
my $auth_module = Test::MockModule->new('C4::AuthoritiesMarc');
$auth_module->mock(
'GuessAuthTypeCode',
sub {
$marcflavour eq 'MARC21' ? return 'PERSO_NAME' : return 'NP';
}
);
# Global variables, mocking and framework modifications
our @linkedrecords;