gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm 

"return" statement with explicit "undef" at line 128, column 74.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 270, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 308, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This commit is contained in:
Mason James 2012-06-27 02:44:47 +12:00 committed by Paul Poulain
parent 16cc80d2bd
commit 7b09ce3a22
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
C4/Output.pm
View File

@ -125,7 +125,7 @@ This function returns HTML, without any language dependency.
=cut
sub pagination_bar {
my $base_url = (@_ ? shift : $ENV{SCRIPT_NAME} . $ENV{QUERY_STRING}) or return undef;
my $base_url = (@_ ? shift : $ENV{SCRIPT_NAME} . $ENV{QUERY_STRING}) or return;
my $nb_pages = (@_) ? shift : 1;
my $current_page = (@_) ? shift : undef; # delay default until later
my $startfrom_name = (@_) ? shift : 'page';
@ -267,7 +267,7 @@ $status is an HTTP status message, like '403 Authentication Required'. It defaul
=cut
sub output_with_http_headers($$$$;$) {
sub output_with_http_headers {
my ( $query, $cookie, $data, $content_type, $status ) = @_;
$status ||= '200 OK';
@ -305,7 +305,7 @@ sub output_with_http_headers($$$$;$) {
print $query->header($options), $data;
}
sub output_html_with_http_headers ($$$;$) {
sub output_html_with_http_headers {
my ( $query, $cookie, $data, $status ) = @_;
output_with_http_headers( $query, $cookie, $data, 'html', $status );
}