From 765adb46e90b4f9ab5d07130affe8f526b66ffe2 Mon Sep 17 00:00:00 2001 From: Caroline Cyr La Rose Date: Wed, 14 Jan 2026 16:45:53 -0500 Subject: [PATCH] Bug 41623: Fix translation pickup in catalogue_details.inc This patch redoes the fix that was made in bug 38450 to make sure the "Waiting at ... since ..." string is picked up by the translation tool. It's a parenthesis move. See bug 38450 for explanation. _("This %s is picked").format(foo) _("This %s is NOT picked".format(bar)) To test: 1. Install a new langage gulp po:update --lang fr-CA ./misc/translator/translate install fr-CA 2. Place a hold 3. Check in the item on hold and confirm the hold 4. Go to the record details page --> Waiting at ... since ... is in English 5. Check the translation files cd misc/translator/po/ git grep "Waiting at" fr-CA* --> There is no "Waiting at %s, %s since %s." 6. Apply patch 7. Update strings again 8. Check translation files again --> The string should be there 9. Translate the string (making sure to remove the fuzzy line if any) 10. Install the translation again (only the translate install part) 11. Check the record details page --> It should be translated! Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass (cherry picked from commit 204b278caaed5ed37e0ca794bd730031ccc757d0) Signed-off-by: Jacob O'Mara --- .../includes/html_helpers/tables/items/catalogue_detail.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc index d74198bdaf..c585f607b4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc @@ -570,9 +570,9 @@ if ( status == 'on_hold') { if ( row.first_hold.waiting_date ) { if ( row.first_hold.desk ) { - nodes += '%s'.format(_("Waiting at %s, %s since %s.".format(row.first_hold._strings.pickup_library_id.str, row.first_hold.desk.desk_name, $date(row.first_hold.waiting_date)))); + nodes += '%s'.format(_("Waiting at %s, %s since %s.").format(row.first_hold._strings.pickup_library_id.str, row.first_hold.desk.desk_name, $date(row.first_hold.waiting_date))); } else { - nodes += '%s'.format(_("Waiting at %s since %s.".format(row.first_hold._strings.pickup_library_id.str, $date(row.first_hold.waiting_date)))); + nodes += '%s'.format(_("Waiting at %s since %s.").format(row.first_hold._strings.pickup_library_id.str, $date(row.first_hold.waiting_date))); } [% IF Koha.Preference('canreservefromotherbranches') %] if ( row.first_hold.waiting_date || row.first_hold.priority == 1 ) {