gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16860: Catch warning t/db_dependent/ClassSource.t 

$ prove t/db_dependent/ClassSource.t
t/db_dependent/ClassSource.t .. 3/24 attempting to use non-existent class sorting routine routine1
t/db_dependent/ClassSource.t .. ok
All tests successful.
Files=1, Tests=24,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.66 cusr  0.02 csys =  0.70 CPU)
Result: PASS

The above warning might be scary to those unfamiliar with the test.
Add a test to catch the warning.

TEST PLAN
---------
1) prove t/db_dependent/ClassSource.t
   -- as above
2) apply patch
3) prove t/db_dependent/ClassSource.t
   -- no message
4) prove -v t/db_dependent/ClassSource.t
   -- test 13 is the new test
5) run koha qa test tools

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Workas as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b80318f1b7)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
This commit is contained in:
Mark Tompsett 2016-07-06 11:51:40 -04:00 committed by Frédéric Demians
parent 6a7fd3ecdc
commit 756f75a044
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
t/db_dependent/ClassSource.t
View File

@ -2,7 +2,8 @@
use Modern::Perl;
use Test::More tests => 24;
use Test::More tests => 25;
use Test::Warn;
use C4::Context;
@ -126,8 +127,12 @@ is_deeply(
);
#Test GetClassSort
my $getclassSort = GetClassSort( 'source1', 'sortrule1', 'item1' )
; #Note: Create a warning:" attempting to use non-existent class sorting routine $sort_routine"
my $getclassSort;
#Note: Create a warning:" attempting to use non-existent class sorting routine $sort_routine"
warning_like
{ $getclassSort = GetClassSort( 'source1', 'sortrule1', 'item1' ) }
qr/attempting to use non-existent class sorting routine/,
'Non-existent class warning caught';
is( $getclassSort, "SORTRULE1_ITEM1",
" the sort key corresponding to Source1 and sortrule1 and item1 is SORTRULE1_ITEM1"
);