gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 33493: (QA follow-up) Only bless the first transfer 

No need to do a walk through on all the results.
Correcting two test descriptions on the way.

Test plan:
Run t/db_dependent/Koha/Item.t
Run t/db_dependent/Koha/Items.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
This commit is contained in:
Marcel de Rooy 2023-06-02 09:10:01 +00:00 committed by Tomas Cohen Arazi
parent 110d74f572
commit 7095ef2fa7
No known key found for this signature in database
GPG Key ID: 0A272EA1B2F3C15F
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Koha/Item.pm
View File

@ -565,9 +565,8 @@ we still expect the item to end up at a final location eventually.
sub get_transfer {
my ($self) = @_;
my $transfer = $self->_result->current_branchtransfers;
return Koha::Item::Transfers->_new_from_dbic($transfer)->next;
my $transfer = $self->_result->current_branchtransfers->next;
return Koha::Item::Transfer->_new_from_dbic($transfer) if $transfer;
}
=head3 get_transfers

2
t/db_dependent/Koha/Item.t
View File

@ -2189,7 +2189,7 @@ subtest 'current_branchtransfers relationship' => sub {
);
my $transfers = $item->_result->current_branchtransfers;
is( ref($transfers), 'DBIx::Class::ResultSet',
'current_branchtransfers returns a Koha::Item::Transfers object set' );
'current_branchtransfers returns a DBIx::Class::ResultSet' );
is( $transfers->count, 0,
"Empty Koha::Item::Transfers set returned if no return_claims" );
my $transfer1 = $builder->build(

2
t/db_dependent/Koha/Items.t
View File

@ -1390,7 +1390,7 @@ subtest 'get_transfer' => sub {
);
$transfer = $new_item_1->get_transfer();
is( ref($transfer), 'Koha::Item::Transfer', 'Koha::Item->get_transfer should return a Koha::Item::Transfers object' );
is( ref($transfer), 'Koha::Item::Transfer', 'Koha::Item->get_transfer should return a Koha::Item::Transfer object' );
my $transfer_2 = $builder->build_object(
{