gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 23049: Capitalise type passed to add_debit for lost_item 

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Martin Renvoize 2019-10-10 16:41:22 +01:00
parent fbd640fa32
commit 70268d49de
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
C4/Accounts.pm
View File

@ -124,7 +124,7 @@ sub chargelostitem {
user_id => C4::Context->userenv ? C4::Context->userenv->{'number'} : undef,
interface => C4::Context->interface,
library_id => C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef,
type => 'lost_item',
type => 'LOST',
item_id => $itemnumber,
issue_id => $issue_id,
}

6
Koha/Account.pm
View File

@ -447,7 +447,7 @@ $debit_type can be any of:
- ACCOUNT
- ACCOUNT_RENEW
- RESERVE_EXPIRED
- lost_item
- LOST
- sundry
- new_card
- overdue
@ -713,7 +713,7 @@ our $offset_type = {
'ACCOUNT_RENEW' => 'Account Fee',
'RESERVE' => 'Reserve Fee',
'PROCESSING' => 'Processing Fee',
'lost_item' => 'Lost Item',
'LOST' => 'Lost Item',
'RENT' => 'Rental Fee',
'RENT_DAILY' => 'Rental Fee',
'RENT_RENEW' => 'Rental Fee',
@ -743,7 +743,7 @@ our $account_type_debit = {
'ACCOUNT' => 'ACCOUNT',
'ACCOUNT_RENEW' => 'ACCOUNT_RENEW',
'RESERVE_EXPIRED' => 'RESERVE_EXPIRED',
'lost_item' => 'LOST',
'LOST_ITEM' => 'LOST',
'sundry' => 'M',
'new_card' => 'N',
'overdue' => 'OVERDUE',

2
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
View File

@ -81,7 +81,7 @@ my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item-
is( $issuingimpossible->{DEBT_GUARANTEES}, undef, "Patron can check out item" );
my $account = Koha::Account->new( { patron_id => $guarantee->id } );
$account->add_debit({ amount => 10.00, type => 'lost_item', interface => 'test' });
$account->add_debit({ amount => 10.00, type => 'LOST', interface => 'test' });
( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );
is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, "Patron cannot check out item due to debt for guarantee" );