Bug 29924: Avoid leaking information on wrong credentials
If the passed credentials are wrong, we shouldn't expose things like the
password is expired.
This patch takes care of that.
To test:
1. Have a known patron with password_expiration_date set so its
password is expired. Can be done like:
$ koha-mysql kohadev
> UPDATE borrowers \
SET password_expiration_date='2022-04-25' \
WHERE borrowernumber=132;
Note: change the borrowernumber
2. Attempt to login to the OPAC with wrong credentials
=> SUCCESS: You are rejected, with a message telling credentials are
wrong
=> FAIL: You are told the password is expired.
3. Apply this patch and restart Plack
4. Repeat 2
=> SUCCESS: You are rejected, credentials are wrong and no mention to
password being expired.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
parent
4e2cfbe75e
commit
6fba85d23b
|
|
@ -1407,7 +1407,6 @@ sub checkauth {
|
|||
PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"),
|
||||
opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'},
|
||||
too_many_login_attempts => ( $patron and $patron->account_locked ),
|
||||
password_has_expired => ( $patron and $patron->password_expired )
|
||||
);
|
||||
|
||||
$template->param( SCO_login => 1 ) if ( $query->param('sco_user_login') );
|
||||
|
|
|
|||
|
|
@ -167,7 +167,7 @@
|
|||
[% END # /IF GoogleOpenIDConnect %]
|
||||
[% END # /UNLESS OPACShibOnly %]
|
||||
|
||||
[% IF password_has_expired %]
|
||||
[% IF !(invalid_username_or_password || too_many_login_attempts) and password_has_expired %]
|
||||
<div class="alert alert-info">
|
||||
<p><strong>Error: </strong>Your password has expired!</p>
|
||||
</div>
|
||||
|
|
|
|||
Loading…
Reference in New Issue