Bug 30620: Add a warning about /*!VERSION lines in kohastructure

Also adding a similar comment in C4::Installer.

No test plan, just documentation.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Marcel de Rooy 2022-04-26 11:45:52 +00:00 committed by Fridolin Somers
parent 4352f855f8
commit 6ec8c3ec89
2 changed files with 6 additions and 0 deletions

View File

@ -285,6 +285,7 @@ sub load_db_schema {
my $datadir = C4::Context->config('intranetdir') . "/installer/data/$self->{dbms}";
# Disable checks before load
# NOTE: These lines are found in kohastructure itself, but DBIx::RunSQL ignores them!
$self->{'dbh'}->do(q{SET NAMES utf8mb4});
$self->{'dbh'}->do(q{SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0});
$self->{'dbh'}->do(q{SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0});

View File

@ -4,6 +4,11 @@
-- ------------------------------------------------------
-- Server version 10.6.5-MariaDB-1:10.6.5+maria~focal
-- IMPORTANT NOTE:
-- The lines with /*! are silently IGNORED when the web installer runs this
-- file (in C4::Installer, using DBIx::RunSQL).
-- The lines only work when you run this sql script directly with mysql.
/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;