Bug 9395: Problem with callnumber and standard number searches
This problem happens because there isn't a operator "phr" in the values of callnumber and standard number search. So many results aren't the corrects ones. Test plan: - Apply the patch - In the dropbox search menu of OPAC main page header, the callnum should have only callnum - In OPAC advanced search the callnumber and standard number options shouldn't have "phr" - In staff client advanced search the callnumber and standard number options shouldn't have "phr" - Change OPACNumbersPreferPhrase and IntranetNumbersPreferPhrase to "use" - The options listed before should use now the operator "phr" - This will resolve the problems with the searches of callnumbers and standard numbers in OPAC and staff client (spaces problems, no results, inconsistent results, etc...) Sponsored-by: KEEP SOLUTIONS Signed-off-by: Owen Leonard <oleonard@myacpl.org> I don't know how to reproduce the searching problems described in the bug, but I can confirm that the patch works correctly to enable/disable the use of 'phr' in the searches described in the test plan. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> System preferences work as described, switching indexes in OPAC and staff. All tests and QA script pass. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
This commit is contained in:
parent
5691663e34
commit
6dcd8f235f
|
|
@ -182,6 +182,9 @@ else {
|
|||
if (C4::Context->preference("marcflavour") eq "UNIMARC" ) {
|
||||
$template->param('UNIMARC' => 1);
|
||||
}
|
||||
if (C4::Context->preference("IntranetNumbersPreferPhrase")) {
|
||||
$template->param('numbersphr' => 1);
|
||||
}
|
||||
|
||||
if($cgi->cookie("holdfor")){
|
||||
my $holdfor_patron = GetMember('borrowernumber' => $cgi->cookie("holdfor"));
|
||||
|
|
|
|||
|
|
@ -411,3 +411,5 @@ INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES (
|
|||
INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES('IDreamBooksReviews','0','Display book review snippets from IDreamBooks.com','','YesNo');
|
||||
INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES('IDreamBooksReadometer','0','Display Readometer from IDreamBooks.com','','YesNo');
|
||||
INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES('IDreamBooksResults','0','Display IDreamBooks.com rating in search results','','YesNo');
|
||||
INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('OPACNumbersPreferPhrase','0', NULL, 'Control the use of phr operator in callnumber and standard number OPAC searches', 'YesNo');
|
||||
INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('IntranetNumbersPreferPhrase','0', NULL, 'Control the use of phr operator in callnumber and standard number staff client searches', 'YesNo');
|
||||
|
|
|
|||
|
|
@ -6399,6 +6399,13 @@ if ( CheckVersion($DBversion) ) {
|
|||
SetVersion($DBversion);
|
||||
}
|
||||
|
||||
$DBversion = "3.11.00.XXX";
|
||||
if ( CheckVersion($DBversion) ) {
|
||||
$dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('OPACNumbersPreferPhrase','0', NULL, 'Control the use of phr operator in callnumber and standard number OPAC searches', 'YesNo')");
|
||||
$dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES ('IntranetNumbersPreferPhrase','0', NULL, 'Control the use of phr operator in callnumber and standard number staff client searches', 'YesNo')");
|
||||
print "Upgrade to $DBversion done (Bug 9395: Problem with callnumber and standard number search in OPAC and Staff Client)\n";
|
||||
SetVersion ($DBversion);
|
||||
}
|
||||
|
||||
=head1 FUNCTIONS
|
||||
|
||||
|
|
|
|||
|
|
@ -20,10 +20,18 @@
|
|||
[% END %]
|
||||
<option value="bc">Barcode</option>
|
||||
<option value="location">Shelving location</option>
|
||||
[% IF (numbersphr) %]
|
||||
<option value="sn,phr">Standard number</option>
|
||||
[% ELSE %]
|
||||
<option value="sn">Standard number</option>
|
||||
[% END %]
|
||||
<option value="nb"> ISBN</option>
|
||||
<option value="ns"> ISSN</option>
|
||||
[% IF (numbersphr) %]
|
||||
<option value="callnum,phr"> Call number</option>
|
||||
[% ELSE %]
|
||||
<option value="callnum"> Call number</option>
|
||||
[% END %]
|
||||
<option value="ln,rtrn">Language</option>
|
||||
<option value="nt">Notes/Comments</option>
|
||||
[% IF (marcflavour != 'UNIMARC' ) %]
|
||||
|
|
|
|||
|
|
@ -79,6 +79,22 @@ Searching:
|
|||
yes: show
|
||||
no: "don't show"
|
||||
- '"More options" on the OPAC and staff advanced search pages.'
|
||||
-
|
||||
- By default,
|
||||
- pref: OPACNumbersPreferPhrase
|
||||
type: boolean
|
||||
choices:
|
||||
yes: use
|
||||
no: "don't use"
|
||||
- 'the operator "phr" in the callnumber and standard number OPAC searches'
|
||||
-
|
||||
- By default,
|
||||
- pref: IntranetNumbersPreferPhrase
|
||||
type: boolean
|
||||
choices:
|
||||
yes: use
|
||||
no: "don't use"
|
||||
- 'the operator "phr" in the callnumber and standard number staff client searches'
|
||||
Results Display:
|
||||
-
|
||||
- By default, sort search results in the staff client by
|
||||
|
|
|
|||
|
|
@ -66,11 +66,19 @@
|
|||
[% ELSE %]
|
||||
<option value="se">Series</option>
|
||||
[% END %]
|
||||
[% IF ( ms_callnum ) %]
|
||||
[% IF ( numbersphr ) %]
|
||||
[% IF ( ms_callnum ) %]
|
||||
<option selected="selected" value="callnum,phr">Call number</option>
|
||||
[% ELSE %]
|
||||
<option value="callnum,phr">Call number</option>
|
||||
[% END %]
|
||||
[% ELSE %]
|
||||
[% IF ( ms_callnum ) %]
|
||||
<option selected="selected" value="callnum">Call number</option>
|
||||
[% ELSE %]
|
||||
[% ELSE %]
|
||||
<option value="callnum">Call number</option>
|
||||
[% END %]</select>
|
||||
[% END %]
|
||||
[% END %]</select>
|
||||
[% IF ( ms_value ) %]
|
||||
<input type="text" title="Type search term" id = "transl1" name="q" value="[% ms_value |html %]" class="left" style="width: 35%; font-size: 111%;"/><div id="translControl"></div>
|
||||
[% ELSE %]
|
||||
|
|
|
|||
|
|
@ -77,7 +77,11 @@
|
|||
[% IF ( expanded_options ) %]
|
||||
<option value="ti,phr"> Title phrase</option>
|
||||
<option value="se,wrdl">Series title</option>
|
||||
[% IF ( numbersphr) %]
|
||||
<option value="callnum,phr">Call number</option>
|
||||
[% ELSE %]
|
||||
<option value="callnum">Call number</option>
|
||||
[% END %]
|
||||
<option value="location">Shelving location</option>
|
||||
[% END %]
|
||||
<option value="au,wrdl">Author</option>
|
||||
|
|
@ -99,10 +103,19 @@
|
|||
<option value="pb,wrdl">Publisher</option>
|
||||
<option value="pl,wrdl">Publisher location</option>
|
||||
[% IF ( expanded_options ) %]
|
||||
[% IF ( numbersphr) %]
|
||||
<option value="sn,phr">Standard number</option>
|
||||
[% ELSE %]
|
||||
<option value="sn">Standard number</option>
|
||||
[% END %]
|
||||
<option value="sn">Standard number</option>
|
||||
<option value="nb"> ISBN</option>
|
||||
<option value="ns"> ISSN</option>
|
||||
[% IF ( numbersphr) %]
|
||||
<option value="lcn,phr"> Call number</option>
|
||||
[% ELSE %]
|
||||
<option value="lcn"> Call number</option>
|
||||
[% END %]
|
||||
[% ELSE %]
|
||||
<option value="nb">ISBN</option>
|
||||
[% END %]
|
||||
|
|
|
|||
|
|
@ -65,4 +65,8 @@ if (C4::Context->preference('GoogleIndicTransliteration')) {
|
|||
$template->param('GoogleIndicTransliteration' => 1);
|
||||
}
|
||||
|
||||
if (C4::Context->preference('OPACNumbersPreferPhrase')) {
|
||||
$template->param('numbersphr' => 1);
|
||||
}
|
||||
|
||||
output_html_with_http_headers $input, $cookie, $template->output;
|
||||
|
|
|
|||
|
|
@ -293,6 +293,11 @@ if ( $template_type && $template_type eq 'advsearch' ) {
|
|||
$template->param( expanded_options => $cgi->param('expanded_options'));
|
||||
}
|
||||
}
|
||||
|
||||
if (C4::Context->preference('OPACNumbersPreferPhrase')) {
|
||||
$template->param('numbersphr' => 1);
|
||||
}
|
||||
|
||||
output_html_with_http_headers $cgi, $cookie, $template->output;
|
||||
exit;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue