gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 35539: Remove 'bulk' column/field from categories table 

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
Pedro Amorim 2024-01-02 11:55:36 +00:00 committed by Martin Renvoize
parent 3d82116830
commit 6d4b201823
No known key found for this signature in database
GPG Key ID: 422B469130441A0F
4 changed files with 7 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Koha/Patron/Category.pm
View File

@ -288,7 +288,6 @@ sub to_api_mapping {
upperagelimit => 'upper_age_limit',
dateofbirthrequired => 'lower_age_limit',
finetype => undef, # Unused
bulk => undef, # Unused
enrolmentfee => 'enrolment_fee',
overduenoticerequired => 'overdue_notice_required',
issuelimit => undef, # Unused

12
installer/data/mysql/en/optional/patron_categories.yml
View File

@ -53,7 +53,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -67,7 +66,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -81,7 +79,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -96,7 +93,6 @@ tables:
upperagelimit: 17
dateofbirthrequired: 5
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -110,7 +106,6 @@ tables:
upperagelimit: 17
dateofbirthrequired: 5
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -124,7 +119,6 @@ tables:
upperagelimit: 17
dateofbirthrequired: 5
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -139,7 +133,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 0
issuelimit: ~
@ -153,7 +146,6 @@ tables:
upperagelimit: 17
dateofbirthrequired: 5
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -168,7 +160,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -182,7 +173,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -196,7 +186,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 1
issuelimit: ~
@ -211,7 +200,6 @@ tables:
upperagelimit: 999
dateofbirthrequired: 18
finetype: ~
bulk: ~
enrolmentfee: '0.000000'
overduenoticerequired: 0
issuelimit: ~

1
installer/data/mysql/kohastructure.sql
View File

@ -1789,7 +1789,6 @@ CREATE TABLE `categories` (
`upperagelimit` smallint(6) DEFAULT NULL COMMENT 'age limit for the patron',
`dateofbirthrequired` tinyint(1) DEFAULT NULL COMMENT 'the minimum age required for the patron category',
`finetype` varchar(30) DEFAULT NULL COMMENT 'unused in Koha',
`bulk` tinyint(1) DEFAULT NULL,
`enrolmentfee` decimal(28,6) DEFAULT NULL COMMENT 'enrollment fee for the patron',
`overduenoticerequired` tinyint(1) DEFAULT NULL COMMENT 'are overdue notices sent to this patron category (1 for yes, 0 for no)',
`issuelimit` smallint(6) DEFAULT NULL COMMENT 'unused in Koha',

16
t/db_dependent/Circulation/GetHardDueDate.t
View File

@ -80,7 +80,6 @@ my $samplecat = {
enrolmentperioddate => undef,
dateofbirthrequired => undef,
finetype => undef,
bulk => undef,
enrolmentfee => undef,
overduenoticerequired => undef,
issuelimit => undef,
@ -89,16 +88,15 @@ my $samplecat = {
category_type => 'A',
};
my $query =
"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired ,finetype,bulk,enrolmentfee,overduenoticerequired,issuelimit ,reservefee ,hidelostitems ,category_type) VALUES( ?,?,?,?,?,?,?,?,?,?,?,?,?)";
"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired ,finetype,enrolmentfee,overduenoticerequired,issuelimit ,reservefee ,hidelostitems ,category_type) VALUES( ?,?,?,?,?,?,?,?,?,?,?,?)";
$dbh->do(
$query, {},
$samplecat->{categorycode}, $samplecat->{description},
$samplecat->{enrolmentperiod}, $samplecat->{enrolmentperioddate},
$samplecat->{dateofbirthrequired}, $samplecat->{finetype},
$samplecat->{bulk}, $samplecat->{enrolmentfee},
$samplecat->{overduenoticerequired}, $samplecat->{issuelimit},
$samplecat->{reservefee}, $samplecat->{hidelostitems},
$samplecat->{category_type}
$samplecat->{categorycode}, $samplecat->{description},
$samplecat->{enrolmentperiod}, $samplecat->{enrolmentperioddate},
$samplecat->{dateofbirthrequired}, $samplecat->{finetype},
$samplecat->{enrolmentfee}, $samplecat->{overduenoticerequired},
$samplecat->{issuelimit}, $samplecat->{reservefee},
$samplecat->{hidelostitems}, $samplecat->{category_type}
);
my $builder = t::lib::TestBuilder->new;