gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 25015: Allow staff with edit_items permissions to edit fast add items 

To test:
1. Set up a user with only catalogue and edit_items permissions
2. Create a Fast Add record with item
    a. Go to Cataloging
    b. Click on Fast Cataloging
    c. Fill in mandatory fields and save the record
    d. Fill in mandatory item fields and click Add item
3. Log in as the user you set up in step 1
4. Search for the record you created in step 2
5. Click Edit > Manage items in the menu at the top of the record
==> You do not have permission to access this page!
6. Go back to biblio record page
7. Apply patch and restart_all
8. Click Edit > Manage items again
==> Edit items page loads normally
9. Make a few edits and confirm that they save correctly

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Emily Lamancusa 2025-03-21 09:42:25 -04:00 committed by Katrin Fischer
parent 44b50d9d44
commit 6bfcd23bdb
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cataloguing/additem.pl
View File

@ -144,13 +144,13 @@ my $display_order = $input->param('item_group_display_order');
our $frameworkcode = &GetFrameworkCode($biblionumber);
# Defining which userflag is needing according to the framework currently used
my $userflags;
my $fast_cataloging_mode;
if ( defined $input->param('frameworkcode') ) {
$userflags = ( $input->param('frameworkcode') eq 'FA' ) ? "fast_cataloging" : "edit_items";
$fast_cataloging_mode = ( $input->param('frameworkcode') eq 'FA' ) ? 1 : 0;
}
if ( not defined $userflags ) {
$userflags = ( $frameworkcode eq 'FA' ) ? "fast_cataloging" : "edit_items";
if ( not defined $fast_cataloging_mode ) {
$fast_cataloging_mode = ( $frameworkcode eq 'FA' ) ? 1 : 0;
}
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
@ -158,7 +158,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
template_name => "cataloguing/additem.tt",
query => $input,
type => "intranet",
flagsrequired => { editcatalogue => $userflags },
flagsrequired =>
{ editcatalogue => $fast_cataloging_mode ? [ 'fast_cataloging', 'edit_items' ] : 'edit_items' },
}
);