From 68219779d0fa7af0fbd07418bc8fe0468f7eaa63 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 6 Jan 2026 16:27:54 +0100
Subject: [PATCH] Bug 41563: Tidy kohaTable - acqui/invoice.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/modules/acqui/invoice.tt           | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
index 58a38e5bd4..abf7218fc2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
@@ -576,16 +576,24 @@
     [% INCLUDE 'calendar.inc' %]
     [% INCLUDE 'datatables.inc' %]
     [% Asset.js("js/modals/edifact-modal.js") | $raw %]
+    <script>
+        addPrefs({
+            AcqEnableFiles: [% Koha.Preference('AcqEnableFiles') ? 1 : 0 | html %],
+        });
+        const invoiceincgst = [% invoiceincgst ? 1 : 0 | html %];
+        const has_files = [% files ? 1 : 0 | html %];
+    </script>
+
     <script>
         function updateColumnsVisibility(visible) {
             if ( visible ) {
                 $("table .tax_excluded, .tax_included").show();
             } else {
-                [% IF ( invoiceincgst ) %]
+                if (invoiceincgst){
                     $("table .tax_excluded").hide();
-                [% ELSE %]
+                } else {
                     $("table .tax_included").hide();
-                [% END %]
+                }
             }
         }
 
@@ -596,14 +604,14 @@
                 searching: false,
                 dom: "t",
             });
-            [% IF ( (Koha.Preference('AcqEnableFiles')) && files ) %]
+            if (prefs.AcqEnableFiles && has_files){
                 $("#invoice_files_table").kohaTable({
                     info: false,
                     paging: false,
                     searching: false,
                     dom: "t",
                 });
-            [% END %]
+            }
             $("#show_all_details").click(function(){
                 updateColumnsVisibility( $(this).is(":checked") );
             });