gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38659: Fix select_manager function when there are no tabs 

To test:
1. Have multiple staff you have permissions to be a purchase suggestion
   manager.
2. Make some suggestions.
3. Edit a suggestion, go down to 'Select manager'.
4. Select a new manager, notice the new one name is not populated.
5. Save the record, the manager is not changed to the new one.
6. APPLY PATCH
7. Try again steps 3-6, but this time the manager field should populate
   and the new manager should be saved when you save the suggestion.
8. Go through the test plan on Bug 38183.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 2a17ad69ea)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Lucas Gass 2024-12-09 22:02:19 +00:00 committed by Paul Derscheid
parent d79e07cc87
commit 65c1d6ccf8
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
View File

@ -1303,8 +1303,13 @@
<script>
function select_manager(borrowernumber, borrower) {
let tab = $('#suggestiontabs .active table').data('tab-name');
var managedby_name = $("#managedby_name-"+tab);
var managedby = $("#managedby-"+tab);
if ( tab ) {
var managedby_name = $("#managedby_name-"+tab);
var managedby = $("#managedby-"+tab);
} else {
var managedby_name = $("#managedby_name");
var managedby = $("#managedby");
}
managedby_name.empty();
managedby.val('');
var borrowername = borrower.firstname + ' ' + borrower.surname;