gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 38505: CirculateILL: Add ILL::Request::check_out regression tests 

prove t/db_dependent/Koha/ILL/Requests.t

Signed-off-by: Ray Delahunty <r.delahunty@arts.ac.uk>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Pedro Amorim 2024-11-21 14:23:55 -01:00 committed by Katrin Fischer
parent ecd0604a8d
commit 642f21a6f2
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 70 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
t/db_dependent/Koha/ILL/Requests.t
View File

@ -1572,7 +1572,7 @@ subtest 'Custom statuses' => sub {
subtest 'Checking in hook' => sub {
plan tests => 2;
plan tests => 6;
$schema->storage->txn_begin;
@ -1626,6 +1626,75 @@ subtest 'Checking in hook' => sub {
$illrq->discard_changes;
is( $illrq->status, 'RET' );
my $request_for_checkout_out = $builder->build_sample_ill_request();
$builder->build(
{
source => 'Illrequestattribute',
value => { illrequest_id => $request_for_checkout_out->illrequest_id, type => 'type', value => 'book' }
}
);
my $newly_created_biblio = Koha::Biblios->find( { biblionumber => $request_for_checkout_out->biblio_id } );
is( $newly_created_biblio->items->count, 0, 'Biblio created without items' );
my $itemtype = $builder->build_object(
{
class => 'Koha::ItemTypes',
value => {
notforloan => 0,
rentalcharge => 0,
rentalcharge_daily => 1,
rentalcharge_daily_calendar => 0
}
}
)->store;
my $check_out = $request_for_checkout_out->check_out(
{
'branchcode' => $request_for_checkout_out->branchcode,
'item_type' => $itemtype->itemtype,
'illrequest_id' => $request_for_checkout_out->illrequest_id,
'stage' => 'form',
}
);
is( $newly_created_biblio->items->count, 1, 'A new item was created after checking out' );
is( $check_out->{value}->{errors}, undef, 'No errors. Check-out was successful' );
# Test if biblio already has an item with no barcode
my $another_checkout_out_request = $builder->build_sample_ill_request();
$builder->build(
{
source => 'Illrequestattribute',
value => { illrequest_id => $another_checkout_out_request->illrequest_id, type => 'type', value => 'book' }
}
);
my $another_newly_created_biblio =
Koha::Biblios->find( { biblionumber => $another_checkout_out_request->biblio_id } );
Koha::Item->new(
{
biblionumber => $another_newly_created_biblio->biblionumber,
homebranch => $another_checkout_out_request->branchcode,
holdingbranch => $another_checkout_out_request->branchcode,
barcode => ''
}
)->store;
my $another_check_out = $another_checkout_out_request->check_out(
{
'branchcode' => $another_checkout_out_request->branchcode,
'item_type' => $itemtype->itemtype,
'illrequest_id' => $another_checkout_out_request->illrequest_id,
'stage' => 'form',
}
);
is(
$another_check_out->{value}->{check_out_errors}->{error}->{UNKNOWN_BARCODE}, 1,
'Barcode related error is set because existing item does not have a barcode'
);
$schema->storage->txn_rollback;
};