gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 15758: [QA Follow-up] Corrections related to GetBranches 

[1] C4/Search
A call to Koha::Libraries is added to routine pazGetRecords, but the
results of that call are not used. So removing it again.

[2] catalogue/itemsearch.pl
Although A=>B=>C=>D works, we'd better use here A=>B, C=>D.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Marcel de Rooy 2016-08-26 13:22:31 +02:00 committed by Kyle M Hall
parent 0079ca7c72
commit 632c78c073
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
C4/Search.pm
View File

@ -854,8 +854,7 @@ sub pazGetRecords {
$results_per_page, $offset, $expanded_facet, $branches,
$query_type, $scan
) = @_;
$branches ||= { map { $_->branchcode => $_->branchname } Koha::Libraries->search };
#NOTE: Parameter $branches is not used here !
my $paz = C4::Search::PazPar2->new(C4::Context->config('pazpar2url'));
$paz->init();

2
catalogue/itemsearch.pl
View File

@ -247,7 +247,7 @@ if (scalar keys %params > 0) {
if ($format eq 'html') {
# Retrieve data required for the form.
my @branches = map { value => $_->branchcode => label => $_->branchname }, Koha::Libraries->search( {}, { order_by => 'branchname' } );
my @branches = map { value => $_->branchcode, label => $_->branchname }, Koha::Libraries->search( {}, { order_by => 'branchname' } );
my @locations;
foreach my $location (@$location_values) {
push @locations, {