From 61cffdc9f3deaa6a8df54bdbeafa51658f6264ae Mon Sep 17 00:00:00 2001 From: Maryse Simard Date: Thu, 5 Feb 2026 17:01:18 -0500 Subject: [PATCH] Bug 41783: Encode query parameters for suggestions filtering When filtering by bibliographic information in the sidebar of the suggestions management page, the '%' contained in the query is not encoded. This can lead to errors if the search terms can be evaluated as an encoded character. Test plan: 1. Go to Acquisitions > Suggestions 2. Create a suggestion with a title like "200 recipes" 3. In "Filter by" > Bibliographic information, search for "200" 4. No results are shown in the table 5. Apply the patch 6. Search again (step 3). The suggestion should appear in the list. Signed-off-by: David Nind Signed-off-by: Brendan Lawlor Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 22b1ad5e13..111c630d95 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -1270,7 +1270,7 @@ order: [[4, "asc"]], autoWidth: false, ajax: { - url: "/api/v1/suggestions?q=" + JSON.stringify(tabSuggestionData.search_params), + url: "/api/v1/suggestions?q=" + encodeURIComponent(JSON.stringify(tabSuggestionData.search_params)), delay: 300, // wait 300 milliseconds before triggering the request cache: true, dataType: "json",