gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 40886: Ensure patron messages display in proper chronological order 

1. Create several random patron circ messages with different dates. I used the following sql for my ktd:
    -- INSERT INTO messages (borrowernumber, branchcode, message_type, message, message_date)
SELECT
    51 AS borrowernumber,
    'CPL' AS branchcode,
    ELT(FLOOR(1 + (RAND() * 3)), 'L','B','E') AS message_type,  -- L=Staff note, B=OPAC, E=Email (adjust to your codes)
    CONCAT('Random test message ', FLOOR(RAND()*1000)) AS message,
    DATE_ADD(CURDATE(), INTERVAL -FLOOR(RAND() * 1825) DAY) AS message_date  -- random day in last ~5 years (5*365)
FROM (
    SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3 UNION ALL SELECT 4 UNION ALL SELECT 5
    UNION ALL SELECT 6 UNION ALL SELECT 7 UNION ALL SELECT 8 UNION ALL SELECT 9 UNION ALL SELECT 10
) AS x;

2. View the patron account and notice that messages are sorted by type, but not by date.
3. Apply the patch and restart_all
4. Refresh the patron account page and clear the browser cache if necessary.
5. View the patron account again and notice that the messages are still sorted by type, but they are also sorted in descending order (newest to oldest).
6. Sign off and have a great day!

Signed-off-by: Jen Tormey <jntormey@dmpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 7be401fcbd)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
This commit is contained in:
Laura_Escamilla 2025-09-26 15:36:40 +00:00 committed by Paul Derscheid
parent 815019cc6c
commit 5ecdbcae32
No known key found for this signature in database
GPG Key ID: C25F9FD44CED595B
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
circ/circulation.pl
View File

@ -739,7 +739,7 @@ if ($patron) {
join => 'manager',
'+select' => [ 'manager.surname', 'manager.firstname' ],
'+as' => [ 'manager_surname', 'manager_firstname' ],
'order_by' => { -desc => 'me.message_type' },
'order_by' => [ 'me.message_type', { -desc => 'me.message_date' }, { -desc => 'me.message_id' } ],
}
);
$template->param( patron_messages => $patron_messages );

2
members/moremember.pl
View File

@ -189,7 +189,7 @@ my $patron_messages = Koha::Patron::Messages->search(
join => 'manager',
'+select' => [ 'manager.surname', 'manager.firstname' ],
'+as' => [ 'manager_surname', 'manager_firstname' ],
'order_by' => { -desc => 'me.message_type' },
'order_by' => [ 'me.message_type', { -desc => 'me.message_date' }, { -desc => 'me.message_id' } ],
}
);