gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report. 

Form - Fixes alphabetization of dropdowns.

Results - Fixes format of "Date last seen" to be the system date preference.  Adds highlighting to the table.

Enables warnings. Pages generated no warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
This commit is contained in:
Garry Collum 2009-08-14 16:14:48 -04:00 committed by Galen Charlton
parent be8d899c98
commit 5d23aafbee
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tmpl
View File

@ -42,7 +42,11 @@
<th>Notes</th>
</tr>
<!-- TMPL_LOOP NAME="itemsloop"-->
<!-- TMPL_UNLESS NAME="__odd__" -->
<tr class="highlight">
<!-- TMPL_ELSE -->
<tr>
<!-- /TMPL_UNLESS -->
<td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber"-->" title="<!-- TMPL_VAR NAME="itemnotes"-->">
<!-- TMPL_VAR NAME="title" escape="html" -->
</a></td>

24
reports/itemslost.pl
View File

@ -23,6 +23,8 @@ This script displays lost items.
=cut
use strict;
use warnings;
use CGI;
use C4::Auth;
use C4::Output;
@ -30,6 +32,7 @@ use C4::Biblio;
use C4::Items;
use C4::Koha; # GetItemTypes
use C4::Branch; # GetBranches
use C4::Dates qw/format_date/;
my $query = new CGI;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
@ -62,6 +65,9 @@ if ( $get_items ) {
$where{$itype} = $itemtypesfilter if defined $itemtypesfilter;
my $items = GetLostItems( \%where, $orderbyfilter );
foreach my $it (@$items) {
$it->{'datelastseen'} = format_date($it->{'datelastseen'});
}
$template->param(
total => scalar @$items,
itemsloop => $items,
@ -71,23 +77,13 @@ if ( $get_items ) {
}
# getting all branches.
my $branches = GetBranches;
my $branch = C4::Context->userenv->{"branchname"};
my @branchloop;
foreach my $thisbranch ( keys %$branches ) {
my $selected = 1 if $thisbranch eq $branch;
my %row = (
value => $thisbranch,
selected => $selected,
branchname => $branches->{$thisbranch}->{'branchname'},
);
push @branchloop, \%row;
}
#my $branches = GetBranches;
#my $branch = C4::Context->userenv->{"branchname"};
# getting all itemtypes
my $itemtypes = &GetItemTypes();
my @itemtypesloop;
foreach my $thisitemtype ( sort keys %$itemtypes ) {
foreach my $thisitemtype ( sort {$itemtypes->{$a}->{description} cmp $itemtypes->{$b}->{description}} keys %$itemtypes ) {
my %row = (
value => $thisitemtype,
description => $itemtypes->{$thisitemtype}->{'description'},
@ -98,7 +94,7 @@ foreach my $thisitemtype ( sort keys %$itemtypes ) {
# get lost statuses
my $lost_status_loop = C4::Koha::GetAuthorisedValues( 'LOST' );
$template->param( branchloop => \@branchloop,
$template->param( branchloop => GetBranchesLoop(C4::Context->userenv->{'branch'}),
itemtypeloop => \@itemtypesloop,
loststatusloop => $lost_status_loop,
);