Bug 38304: Remove SaveState options for OPAC tables

On /admin/columns_settings.pl you can select the two options related to SaveState for the OPAC tables, but those tables do not show the filters and column filters. Also the work on bug 33484 is not implemented at the OPAC

  Save configuration state on page change:
  Save search state on page change:

We could remove those options for those tables to remove ambiguity.

Test plan:
Go the the table settings and open the "OPAC" tab.
Notice that the options are no longer displayed (but they are still for
the other tabs)
Modify some settings
Save and confirm the settings have been correctly saved.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
This commit is contained in:
Jonathan Druart 2024-10-30 16:55:34 +01:00 committed by Katrin Fischer
parent 801b58439b
commit 593cd04f1e
No known key found for this signature in database
GPG Key ID: 0EF6E2C03357A834
1 changed files with 20 additions and 18 deletions

View File

@ -149,25 +149,27 @@
</p>
[% END %]
<p>
[% SET option_name = pagename _ "|" _ tablename _ "_default_save_state" %]
<label for="[% option_name | html %]" title="Save the column visibility, length of the table and order in session">Save configuration state on page change:</label>
[%- IF table_settings.default_save_state -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
[%- ELSE -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
[%- END -%]
</p>
[% IF modulename != 'opac' %]
<p>
[% SET option_name = pagename _ "|" _ tablename _ "_default_save_state" %]
<label for="[% option_name | html %]" title="Save the column visibility, length of the table and order in session">Save configuration state on page change:</label>
[%- IF table_settings.default_save_state -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
[%- ELSE -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
[%- END -%]
</p>
<p>
[% SET option_name = pagename _ "|" _ tablename _ "_default_save_state_search" %]
<label for="[% option_name | html %]" title="Save the search and filtering in session">Save search state on page change:</label>
[%- IF table_settings.default_save_state_search -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
[%- ELSE -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
[%- END -%]
</p>
<p>
[% SET option_name = pagename _ "|" _ tablename _ "_default_save_state_search" %]
<label for="[% option_name | html %]" title="Save the search and filtering in session">Save search state on page change:</label>
[%- IF table_settings.default_save_state_search -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
[%- ELSE -%]
<input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
[%- END -%]
</p>
[% END %]
</div>
[% END %]