gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 16314: Show upload link for upload plugin in basic MARC editor 

This patch updates the basic MARC editor to provide a plugin name
variable to the template, allowing us to make a check on the name and
conditionally show an upload link if the "upload.pl" cataloging plugin
is selected.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

 - Go do Administration -> MARC bibliographic framework -> MARC
   structure -> 856 -> Edit subfields.
 - Edit the "u" subfield and select "upload.pl" as the plugin under
   "Other options."
 - Go to Cataloging and create or edit a MARC record.
 - Under tab 8 look for the 856 tag, subfield u. There should be an
   "Upload" link corresponding to the form field.
 - Click the upload link to confirm that it triggers a popup window with
   the upload form.
 - Confirm that other similar plugin links (for instance 100$a, 600$a)
   display the old "tag editor" icon.

Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit bdb64657f9)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
This commit is contained in:
Owen Leonard 2020-07-11 13:25:11 +00:00 committed by Lucas Gass
parent 09b5ffe121
commit 5906f9c3fb
4 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cataloguing/addbiblio.pl
View File

@ -390,6 +390,7 @@ sub create_input {
size => 67,
maxlength => $subfield_data{maxlength},
javascript => $plugin->javascript,
plugin => $plugin->name,
noclick => $plugin->noclick,
};
} else {

1
cataloguing/value_builder/upload.pl
View File

@ -35,6 +35,7 @@ my $builder = sub {
return <<"SCRIPT";
<script type=\"text/javascript\">
function Click$params->{id}(event) {
event.preventDefault();
var index = event.data.id;
var str = document.getElementById(index).value;
var myurl, term;

9
koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
View File

@ -3397,6 +3397,15 @@ progress {
text-indent: 100%;
white-space: nowrap;
width: 16px;
&.upload {
background: transparent none;
font-size: 90%;
height: unset;
overflow: unset;
text-indent: unset;
width: unset;
}
}
.browse-controls {

6
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
View File

@ -837,7 +837,11 @@
[% IF mv.noclick %]
<span class="buttonDot tag_editor disabled" tabindex="-1" title="Field autofilled by plugin"></span>
[% ELSE %]
<a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor framework_plugin" tabindex="1" title="Tag editor">Tag editor</a>
[% IF mv.plugin == "upload.pl" %]
<a href="#" id="buttonDot_[% mv.id | html %]" class="tag_editor upload framework_plugin" tabindex="1"><i class="fa fa-upload" aria-hidden="true"></i> Upload</a>
[% ELSE %]
<a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor framework_plugin" tabindex="1" title="Tag editor">Tag editor</a>
[% END %]
[% END %]
</span>
[% mv.javascript | $raw %]