Bug 14708: Prevent deletion of Anonymous Patron at Koha::Patron::delete
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 63960cbb89)
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
This commit is contained in:
parent
f42d12bd5f
commit
5491d1d421
|
|
@ -361,6 +361,9 @@ other lists are kept.
|
|||
sub delete {
|
||||
my ($self) = @_;
|
||||
|
||||
my $anonymous_patron = C4::Context->preference("AnonymousPatron");
|
||||
return $self if $anonymous_patron && $self->id eq $anonymous_patron;
|
||||
|
||||
$self->_result->result_source->schema->txn_do(
|
||||
sub {
|
||||
# Cancel Patron's holds
|
||||
|
|
|
|||
|
|
@ -1063,7 +1063,7 @@ subtest 'notice_email_address' => sub {
|
|||
};
|
||||
|
||||
subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
|
||||
plan tests => 4;
|
||||
plan tests => 5;
|
||||
|
||||
# TODO create a subroutine in t::lib::Mocks
|
||||
my $branch = $builder->build({ source => 'Branch' });
|
||||
|
|
@ -1077,6 +1077,15 @@ subtest 'search_patrons_to_anonymise & anonymise_issue_history' => sub {
|
|||
|
||||
t::lib::Mocks::mock_preference( 'AnonymousPatron', $anonymous->{borrowernumber} );
|
||||
|
||||
subtest 'Anonymous Patron should be undeleteable' => sub {
|
||||
plan tests => 1;
|
||||
|
||||
my $anonymous_patron = Koha::Patrons->find( $anonymous->{borrowernumber} );
|
||||
$anonymous_patron->delete();
|
||||
$anonymous_patron = Koha::Patrons->find( $anonymous->{borrowernumber} );
|
||||
is( $anonymous_patron->id, $anonymous->{borrowernumber}, "Anonymous Patron was not deleted" );
|
||||
};
|
||||
|
||||
subtest 'patron privacy is 1 (default)' => sub {
|
||||
plan tests => 9;
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue