Bug 19108 - Stored XSS in classsources.pl

Fixed for both Classification sources & Classification filing rules

To Test
1. first case classification source: Hit the page
   /cgi-bin/koha/admin/classsources.pl?op=add_source
   second case classification filing rules:
   Hit the page /cgi-bin/koha/admin/classsources.pl?op=add_sort_rule
2. Add a text in the field Description that contains js
3. Save the page.
4. Notice js is execute
5. Apply patch and reload, the js is escaped

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 940c8634914b50940cfaf73af3611e6282d5803f)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 64abaa063d)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This commit is contained in:
Amit Gupta 2017-08-15 13:55:45 +05:30 committed by Katrin Fischer
parent c092ea7261
commit 543aef4ead
1 changed files with 2 additions and 2 deletions

View File

@ -210,7 +210,7 @@
[% FOREACH class_source IN class_sources %]
<tr>
<td>[% class_source.code %]</td>
<td>[% class_source.description %]</td>
<td>[% class_source.description |html %]</td>
<td>[% IF ( class_source.used ) %]Yes[% ELSE %]No[% END %]</td>
<td>[% class_source.sortrule %]</td>
<td class="actions">
@ -241,7 +241,7 @@
[% FOREACH class_sort_rule IN class_sort_rules %]
<tr>
<td>[% class_sort_rule.rule %]</td>
<td>[% class_sort_rule.description %]</td>
<td>[% class_sort_rule.description |html %]</td>
<td>[% class_sort_rule.sort_routine %]</td>
<td class="actions">
<a class="btn btn-mini" href="[% class_sort_rule.script_name %]?op=edit_sort_rule&amp;sort_rule=[% class_sort_rule.rule |html %]"><i class="fa fa-pencil"></i> Edit</a>