Bug 19847: Track links within the records and 404 for others

Test plan:
Behave like a robot, you will get 404
Be a human, you will be tracked

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This commit is contained in:
Jonathan Druart 2017-12-20 12:13:10 -03:00
parent b59988f78d
commit 51b6cf2aaf
1 changed files with 18 additions and 14 deletions

View File

@ -21,6 +21,7 @@
use Modern::Perl;
use C4::Context;
use C4::Auth qw(checkauth);
use C4::Biblio;
use Koha::Linktracker;
use CGI qw ( -utf8 );
@ -54,25 +55,28 @@ if ($uri) {
my $biblionumber = $cgi->param('biblionumber') || 0;
my $itemnumber = $cgi->param('itemnumber') || 0;
$tracker->trackclick(
{
uri => $uri,
biblionumber => $biblionumber,
borrowernumber => $borrowernumber,
itemnumber => $itemnumber
}
);
print $cgi->redirect($uri);
my $record = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber });
my $marc_urls = C4::Biblio::GetMarcUrls($record, C4::Context->preference('marcflavour'));
if ( grep { /^$uri$/ } map { $_->{MARCURL} } @$marc_urls ) {
$tracker->trackclick(
{
uri => $uri,
biblionumber => $biblionumber,
borrowernumber => $borrowernumber,
itemnumber => $itemnumber
}
);
print $cgi->redirect($uri);
exit;
}
}
else {
# We have a valid url, but we shouldn't track it, just redirect
print $cgi->redirect($uri);
exit;
}
}
else {
# we shouldn't be here, bail out
print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early
exit;
}
print $cgi->redirect("/cgi-bin/koha/errors/404.pl"); # escape early
exit;